Revert sample test to mitigate test flakiness #277
Conversation
|
/assign @gaoning777 @yebrahim @Ark-kun |
|
/approve |
|
This doesn't look to me like a clean revert. Can you explain the change? |
|
I got "Sorry, this pull request couldn’t be reverted automatically. It may have already been reverted, or the content may have changed since it was merged." when i click revert button. this change instead commented out the tests. |
|
/lgtm |
|
/test presubmit-e2e-test |
1 similar comment
|
/test presubmit-e2e-test |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: IronPan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Did the flakiness result from the frontend integration tests or the basic e2e sample test? |
|
The failures were in the frontend integration test as far as I've seen. |
|
Shouldn't we keep the basic e2e sample tests then because it helps to test the consistency between dsl and pipeline system and make sure the basic sample tests are working e2e? @IronPan |
|
Yes, we should do this revert properly, but it was good to unblock tests quickly too. |
* add kubeflow_label.yml for label sycn across repos in kubeflow, along with helper script to generate it. * reformat process_label.py to fix pylint check * handle code review feedback & change code to python3 * Enable image auto release -- testing repo part * formating py following pylint * update image version tag format * fix presubmit
#272
This change is