Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix inverse proxy matching regex #2486

Merged
merged 1 commit into from
Oct 24, 2019
Merged

Fix inverse proxy matching regex #2486

merged 1 commit into from
Oct 24, 2019

Conversation

IronPan
Copy link
Member

@IronPan IronPan commented Oct 24, 2019

The new format is now
36a59b5371d6ab2-dot-us-west1.notebooks.googleusercontent.com
Remove the part that break the SDL to use a more generic matching string
/assign @numerology @hongye-sun


This change is Reviewable

The new format is now 
36a59b5371d6ab2-dot-us-west1.notebooks.googleusercontent.com
Remove the part that break the SDL to use a more generic matching string 
/assign @numerology @hongye-sun
@numerology
Copy link

/lgtm

@IronPan
Copy link
Member Author

IronPan commented Oct 24, 2019

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: IronPan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 8032b50 into master Oct 24, 2019
@IronPan IronPan deleted the IronPan-patch-4 branch October 30, 2019 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants