Skip to content

Commit

Permalink
Fix inverse proxy matching regex (#2486)
Browse files Browse the repository at this point in the history
The new format is now 
36a59b5371d6ab2-dot-us-west1.notebooks.googleusercontent.com
Remove the part that break the SDL to use a more generic matching string 
/assign @numerology @hongye-sun
  • Loading branch information
IronPan authored and k8s-ci-robot committed Oct 24, 2019
1 parent bb6066a commit 8032b50
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion sdk/python/kfp/_client.py
Original file line number Diff line number Diff line change
Expand Up @@ -152,7 +152,7 @@ def _is_iap_host(self, host, client_id):

def _is_inverse_proxy_host(self, host):
if host:
return re.match(r'\S+dot-datalab-vm\S+.googleusercontent.com/{0,1}$', host)
return re.match(r'\S+.googleusercontent.com/{0,1}$', host)
return False

def _is_ipython(self):
Expand Down

0 comments on commit 8032b50

Please sign in to comment.