[Frontend] Fix log viewer cannot scroll horizontally + other minor issues #2480
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/lgtm |
|
@jingzhang36 Thanks! |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Bobgy The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Bobgy
changed the title
Bobgy
changed the title
magdalenakuhn17
pushed a commit
to magdalenakuhn17/pipelines
that referenced
this pull request
Oct 22, 2023
Signed-off-by: Suresh-Nakkeran <suresh.n@ideas2it.com> Signed-off-by: Suresh-Nakkeran <suresh.n@ideas2it.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug double scrollbar:
Bug cannot scroll horizontally (introduced by me in #2370), notice in the screenshot, log lines are long, but there is no horizontal scrollbar:
Bug "not scrolling to bottom", when user goes to log viewer tab, it should go to the bottom line of logs. However, it goes to a few pixels above that.
This fixes three of them.
Demo: https://drive.google.com/file/d/1xpZYI5QYlbzBquGxxKGfF4ukL91WA1MM/view
This change is