[Frontend] Fix cannot copy logs in LogViewer when scrolling #2370
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 11, 2019
Bobgy
changed the title
|
Didn't add related tests for this, because our test infra doesn't run tests in a real browser. Features added here cannot be tested in js dom simulated environment. |
Bobgy
changed the title
|
@jingzhang36 Can you help me review? |
|
/lgtm |
…; Changed snapshots to mount + getDOMNode to be invariant to internal refactoring
|
@jingzhang36 I updated to fix snapshot tests. Can you relgtm again? |
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Bobgy The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This was referenced Oct 23, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
1000400 lines of extra logs above and below visible part now. (so we can select more logs)Fixes #1508
DEMO: https://drive.google.com/file/d/1jTg0mztuT0_Vq2lkRlQnjS0i8PEP3vdo/view
Ask for review about the solution. When it sounds good, I will add tests and tidy up code.
/area front-end
/kind bug
This change is