Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Samples - Simplified pipeline submission code in samples #2293

Merged
merged 1 commit into from
Oct 4, 2019
Merged

Samples - Simplified pipeline submission code in samples #2293

merged 1 commit into from
Oct 4, 2019

Conversation

Ark-kun
Copy link
Contributor

@Ark-kun Ark-kun commented Oct 3, 2019 •
edited by jlewi
Loading

Reduced boilerplate code in samples by switching to kfp.Client().create_run_from_pipeline_package which:

  • compiles the pipeline
  • gets or creates the experiment (name is optional)
  • generates unique run name
  • submits the run

This change is Reviewable

@Ark-kun
Samples - Simplified pipeline submission code in samples
faf0cdd 
Reduced boilerplate code in samples by switching to `kfp.Client().create_run_from_pipeline_package` which:
* compiles the pipeline
* gets or creates the experiment (name is optional)
* generates unique run name
* submits the run
@Ark-kun Ark-kun force-pushed the Samples---Simplified-pipeline-submission-code-in-samples branch from e68deba to faf0cdd Compare October 3, 2019 02:57
@Ark-kun
Copy link
Contributor Author

Ark-kun commented Oct 4, 2019

Talked offline with @hongye-sun who previously reviewed and approved the create_run_from_pipeline_package method ( #1484 ). Hongye has approved this PR change since it makes samples smaller and easier for the users (especially when resubmitting pipelines) while leaving an easy way to override any setting like KPF host, experiment name or run name.
P.S. This function is just high-level API. The kfp.compiler.* or kfp.Client().* APIs remain the same.

@numerology
Copy link

/lgtm

@Ark-kun
Copy link
Contributor Author

Ark-kun commented Oct 4, 2019

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Ark-kun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 1e6ce6b into kubeflow:master Oct 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@numerology numerology numerology left review comments

@gaoning777 gaoning777 Awaiting requested review from gaoning777

@hongye-sun hongye-sun Awaiting requested review from hongye-sun

@animeshsingh animeshsingh Awaiting requested review from animeshsingh

Assignees

@numerology numerology

@SinaChavoshi SinaChavoshi

@hongye-sun hongye-sun

Labels
approved area/samples/notebooks area/samples lgtm size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Ark-kun @numerology @k8s-ci-robot @SinaChavoshi @hongye-sun