Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SDK - Make it easier to compile and submit a pipeline run #1484

Conversation

Ark-kun
Copy link
Contributor

@Ark-kun Ark-kun commented Jun 11, 2019

Adds the Client.run_pipeline_func_on_kfp(func) function that compiles the pipeline and submits it for execution on KFP-enabled cluster.


This change is Reviewable

Adds the `Client.run_pipeline_func_on_kfp(func)` function that compiles the pipeline and submits it for execution on KFP-enabled cluster.
@Ark-kun Ark-kun force-pushed the SDK---Make-it-easier-to-compile-and-submit-a-pipeline-run branch from a2e6930 to e2bd45b Compare June 11, 2019 21:16
@gaoning777
Copy link
Contributor

In fact, I'm seeing too much benefits from this API because users still need to input many arguments. On the other hand, exposing more interfaces means more work for backward compatibility support.
@hongye-sun WDYT?

@Ark-kun
Copy link
Contributor Author

Ark-kun commented Jun 17, 2019

I'm seeing too much benefits from this API because users still need to input many arguments.

The users only need pipeline_func and arguments. Everything else is optional.

This function greatly reduces the common boilerplate everyone has to do especially when developing in notebook. Makoto had the same usability issue and had to write the same helper function.
I think this is a case where a small addition makes usability much better.

Copy link
Contributor

@hongye-sun hongye-sun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@Ark-kun
Copy link
Contributor Author

Ark-kun commented Jun 17, 2019

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Ark-kun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 8d5d264 into kubeflow:master Jun 17, 2019
@Ark-kun Ark-kun deleted the SDK---Make-it-easier-to-compile-and-submit-a-pipeline-run branch June 17, 2019 23:02
magdalenakuhn17 pushed a commit to magdalenakuhn17/pipelines that referenced this pull request Oct 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants