SDK - Compiler - Fix large data passing #2173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stop outputting parameters unless they're consumed as parameters downstream. This prevents the situaltion when component outputs a big file, but DSL compiler instructs Argo to pick it up as parameter (parameters only hold few kilobytes of data). As byproduct, this change fixes some minor compiler data passing bugs where some parameters were being passed around, but never consumed (happened with `ResourceOp`, `dsl.Condition` and recursion).
Ark-kun
force-pushed
the
SDK---Compiler---Fix-large-data-passing
branch
from
a2f2346
to
091d5ec
Compare
numerology
reviewed
Sep 19, 2019
numerology
reviewed
Sep 19, 2019
|
/restart |
|
/test kubeflow-pipeline-e2e-test |
1 similar comment
|
/test kubeflow-pipeline-e2e-test |
Ark-kun
changed the title
Ark-kun
force-pushed
the
SDK---Compiler---Fix-large-data-passing
branch
from
29602d6
to
84b8096
Compare
Ark-kun
changed the title
numerology
reviewed
Sep 20, 2019
| # workflow.parameters.* placeholders are not supported, but the DSL compiler does not produce those. | ||
| template_input_to_parent_constant_arguments.setdefault((task_template_name, task_input_name), set()).add(argument_value) | ||
| else: | ||
| raise AssertionError |
There was a problem hiding this comment.
nit: Maybe add some text like AssertionError('Unknown placeholder type encountered')?
numerology
reviewed
Sep 20, 2019
| input_name = parts[2] | ||
| inputs_directly_consumed_as_parameters.add((template_name, input_name)) | ||
| elif parts[1] == 'artifacts': | ||
| raise AssertionError # Should not happen in container templates |
There was a problem hiding this comment.
nit: I think it will be great to add some debug info in the AssertionError, too.
numerology
reviewed
Sep 20, 2019
| ] | ||
|
|
||
| # Fix Workflow parameter arguments that are consumed as artifacts downstream | ||
| # |
|
/lgtm Left comments on some nit things. |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Ark-kun The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This was referenced Oct 4, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change makes compiler stop outputting parameters unless they're consumed as parameters downstream.
This prevents the situation when component outputs a big file, but DSL compiler instructs Argo to pick it up as parameter (parameters only hold few kilobytes of data).
As byproduct, this change fixes some minor compiler data passing bugs where some parameters were being passed around, but never consumed (happened with
dsl.Conditionand recursion).Fixes #336.
This change is