Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Artifact representation in Pipeline #1003

Closed
animeshsingh opened this issue Mar 20, 2019 · 5 comments
Closed

Artifact representation in Pipeline #1003

animeshsingh opened this issue Mar 20, 2019 · 5 comments

Comments

@animeshsingh
Copy link
Contributor

Are there any thoughts on how to define custom artifacts in pipelines which different steps can consume? For e.g. if we need to bring in a model as a typed artifact object, which a pipeline can consume, and it can be defined in DSL

@Ark-kun Ark-kun self-assigned this Mar 20, 2019
@Ark-kun
Copy link
Contributor

Ark-kun commented Mar 20, 2019

A good way that also follows Argo would be to add the input_artifact_paths and output_artifact_paths parameters to the ContainerOp constructor, so that it's possible to specify the artifact names and file locations where the system should place or collect them.
output_artifact_paths={"out_art1": "/outputs/out_art1/data", ...}
input_artifact_paths={"in_art1": "/inputs/in_art1/data", ...}

See Argo example on how the artifact inputs/outputs and artifact passing is described in Argo: https://github.com/argoproj/argo/blob/master/examples/artifact-passing.yaml

Adding the artifact production support to the DSL compiler is easy.
Adding the artifact consumption support to the DSL compiler is more complicated as the compiler code is quite convoluted.

@hongye-sun
Copy link
Contributor

@animeshsingh would you mind giving us more context of your use cases about typed artifact object?

We are in an effort to support artifact metadata (including location, type and runtime data) tracking in a metadata store. For consuming artifact inside a pipeline, we are still open to advice.

@Ark-kun
Copy link
Contributor

Ark-kun commented May 14, 2019

Specifying output artifacts is now possible since
#998
Input artifacts are waiting for #791 to be merged .
Then we'll need to update the compiler to support passing output artifacts to artifact inputs.

@gaoning777
Copy link
Contributor

@animeshsingh same as hongye, more context is welcome. Is this issue about defining custom artifact types or artifact passing, or both? Thanks

@Ark-kun Ark-kun self-assigned this Oct 4, 2019
@Ark-kun
Copy link
Contributor

Ark-kun commented Oct 4, 2019

Fixed by #791, #998 , #2173

@Ark-kun Ark-kun closed this as completed Oct 4, 2019
Linchin pushed a commit to Linchin/pipelines that referenced this issue Apr 11, 2023
…flow#1003)

* Deprecate existing kubeflow repos presubmit

This is the PR for deprecating existing kubeflow repository's presubmit depending on optional-test-infra.

* Update config files
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants