Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SDK - Fix pipeline metadata serialization #2137

Merged

Commits on Sep 17, 2019

  1. SDK - Fix pipeline metadata serialization

    Two PRs have been merged that turned out to be slightly incompatible. This PR fixes the failing tests.
    Root causes:
    * The pipeline parameter default values were not properly serialized when constructing the metadata object.
    * The `ParameterMeta` class did not validate the default value type, so the lack of serialization has not been caught. The `ParameterMeta` was replaced by `InputSpec` which has strict type validation.
    * Previously we did not have samples with complex pipeline parameter default values (e.g. lists) that could trigger the failures. Then two samples were added that had complex default values.
    * Travis does not re-run tests before merging
    * Prow does not re-run Travis tests before merging
    Ark-kun committed Sep 17, 2019
    Configuration menu
    Copy the full SHA
    6a265f3 View commit details
    Browse the repository at this point in the history