SDK - Fix pipeline metadata serialization #2137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ark-kun
force-pushed
the
SDK---Fix-pipeline-metadata-serialization
branch
from
cf87436
to
6f21c73
Compare
Two PRs have been merged that turned out to be slightly incompatible. This PR fixes the failing tests. Root causes: * The pipeline parameter default values were not properly serialized when constructing the metadata object. * The `ParameterMeta` class did not validate the default value type, so the lack of serialization has not been caught. The `ParameterMeta` was replaced by `InputSpec` which has strict type validation. * Previously we did not have samples with complex pipeline parameter default values (e.g. lists) that could trigger the failures. Then two samples were added that had complex default values. * Travis does not re-run tests before merging * Prow does not re-run Travis tests before merging
Ark-kun
force-pushed
the
SDK---Fix-pipeline-metadata-serialization
branch
from
6f21c73
to
6a265f3
Compare
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Ark-kun The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two PRs have been merged that turned out to be slightly incompatible. This PR fixes the failing tests.
Root causes:
ParameterMetaclass did not validate the default value type, so the lack of serialization has not been caught. TheParameterMetawas replaced byInputSpecwhich has strict type validation.This change is