Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SDK/Components - Fixes and more tests #213

Merged
merged 7 commits into from
Nov 15, 2018
Merged

SDK/Components - Fixes and more tests #213

merged 7 commits into from
Nov 15, 2018

Conversation

Ark-kun
Copy link
Contributor

@Ark-kun Ark-kun commented Nov 12, 2018 •
edited by jlewi
Loading

This change is Reviewable

@coveralls
Copy link

coveralls commented Nov 12, 2018 •
edited
Loading

Pull Request Test Coverage Report for Build 311

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 67.506%
Totals Coverage Status
Change from base Build 225: 0.0%
Covered Lines: 1535
Relevant Lines: 2182
💛 - Coveralls

@Ark-kun Ark-kun force-pushed the avolkov/SDK/Components---Fixes-and-tests branch from 4519b35 to 4d4487f Compare November 12, 2018 09:54
@Ark-kun Ark-kun mentioned this pull request Nov 12, 2018
Merged
gaoning777
gaoning777 approved these changes Nov 14, 2018
View reviewed changes
Copy link
Contributor

@gaoning777 gaoning777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@Ark-kun
Copy link
Contributor Author

Ark-kun commented Nov 14, 2018

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Ark-kun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Ark-kun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Ark-kun
Copy link
Contributor Author

Ark-kun commented Nov 14, 2018

/test presubmit-e2e-test

3 similar comments
@Ark-kun
Copy link
Contributor Author

Ark-kun commented Nov 15, 2018

/test presubmit-e2e-test

@Ark-kun
Copy link
Contributor Author

Ark-kun commented Nov 15, 2018

/test presubmit-e2e-test

@Ark-kun
Copy link
Contributor Author

Ark-kun commented Nov 15, 2018

/test presubmit-e2e-test

@Ark-kun
Copy link
Contributor Author

Ark-kun commented Nov 15, 2018

/test build-image

@Ark-kun
Copy link
Contributor Author

Ark-kun commented Nov 15, 2018

/test presubmit-e2e-test

@Ark-kun
Copy link
Contributor Author

Ark-kun commented Nov 15, 2018

/test presubmit-e2e-test

@Ark-kun
Copy link
Contributor Author

Ark-kun commented Nov 15, 2018

/test build-image

1 similar comment
@Ark-kun
Copy link
Contributor Author

Ark-kun commented Nov 15, 2018

/test build-image

@k8s-ci-robot k8s-ci-robot merged commit 0c6fef8 into master Nov 15, 2018
@Ark-kun Ark-kun deleted the avolkov/SDK/Components---Fixes-and-tests branch January 15, 2019 22:09
HumairAK pushed a commit to red-hat-data-services/data-science-pipelines that referenced this pull request Mar 11, 2024
@ckadner
Remove build.sh in favor of make distribution (kubeflow#213)
e0f01c4 
Using the build.sh script is dangerous as it does not ensure
the safeguard of a virtual environment. It modifies the users
current Python environment, which could be the system Python
environment. This could cause problems with incompatible
Python packages, and it can be tedious at best to restore
the original Python environment.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gaoning777 gaoning777 gaoning777 approved these changes

@qimingj qimingj Awaiting requested review from qimingj

Assignees

@gaoning777 gaoning777

Labels
approved area/sdk/components lgtm size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Ark-kun @coveralls @k8s-ci-robot @gaoning777