Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SDK/Components - Support for optional inputs #214

Merged
merged 3 commits into from
Nov 30, 2018

Conversation

Ark-kun
Copy link
Contributor

@Ark-kun Ark-kun commented Nov 12, 2018

This change adds support for loading and "materializing" components with optional inputs. The default values are not yet supported.


This change is Reviewable

@coveralls
Copy link

coveralls commented Nov 12, 2018

Pull Request Test Coverage Report for Build 244

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 67.506%

Totals Coverage Status
Change from base Build 225: 0.0%
Covered Lines: 1535
Relevant Lines: 2182

💛 - Coveralls

@Ark-kun
Copy link
Contributor Author

Ark-kun commented Nov 12, 2018

/retest

@Ark-kun Ark-kun force-pushed the avolkov/SDK/Components---Optional-inputs-3 branch from 141a1e1 to d01a44f Compare November 16, 2018 01:53
@qimingj
Copy link
Contributor

qimingj commented Nov 30, 2018

/lgtm

@Ark-kun
Copy link
Contributor Author

Ark-kun commented Nov 30, 2018

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Ark-kun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

1 similar comment
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Ark-kun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 9110296 into master Nov 30, 2018
@Ark-kun Ark-kun deleted the avolkov/SDK/Components---Optional-inputs-3 branch January 15, 2019 22:09
magdalenakuhn17 pushed a commit to magdalenakuhn17/pipelines that referenced this pull request Oct 22, 2023
* Add general code for generating schema

* need to cover different cases of row vs column format, single vs multi
tensor

* Generate schema for row fmt with multiple tensors

* Refactor row fmt generation for single and multi tensors

* Add column fmt generation

* Remove hardcoding in OpenAPI wrapper

* Cleanup code and add instances key for OpenAPI row fmt

* Refactor functions

* Add tests for TFTensor2OpenAPI

* Stop OpenAPI if shape is 0

* Test with full coverage

* Remove nested if else

* Improve readability

* Condense comments

* Add Metagraph and SigDef selection

* Add MetaGraph,SigDef unit tests

* Reorganize TFDType

* Clean up generator

* Fix nondeterminism in tests by ignoring array order

* Add metagraph selection to CLI

* Add metagraph tags to README

* Minor style fixes

* Fix builder pattern and make error msgs constant

* Remove obsolete generator methods

* Change generator names

* Change receiver name
HumairAK pushed a commit to red-hat-data-services/data-science-pipelines that referenced this pull request Mar 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants