Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Testing - Fixed the comparison bug in presubmit test script #1990

Merged
merged 2 commits into from
Aug 30, 2019
Merged

Testing - Fixed the comparison bug in presubmit test script #1990

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2ca3222
Testing - Fixed the comparison bug in presubmit test script
Ark-kun Aug 28, 2019
8ac04de
Addressed the feedback
Ark-kun Aug 29, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions test/presubmit-tests-with-pipeline-deployment.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,9 +65,7 @@ done

# PULL_PULL_SHA is empty whne Pros/Tide tests the batches.
# PULL_BASE_SHA cannot be used here as it still points to master tip in that case.
if [ -z "${PULL_PULL_SHA:-''}" ]; then
PULL_PULL_SHA=$(git rev-parse HEAD)
fi
PULL_PULL_SHA="${PULL_PULL_SHA:-$(git rev-parse HEAD)}"

# Variables
GCR_IMAGE_BASE_DIR=gcr.io/${PROJECT}/${PULL_PULL_SHA}
Expand Down