Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testing - Fixed the comparison bug in presubmit test script #1990

Conversation

Ark-kun
Copy link
Contributor

@Ark-kun Ark-kun commented Aug 29, 2019

Bash was treating the single quotes literally.


This change is Reviewable

Bash was treating the single quotes literally.
@Bobgy
Copy link
Contributor

Bobgy commented Aug 29, 2019

/lgtm

@Ark-kun Ark-kun force-pushed the avolkov/Testing---Fixed-the-comparison-bug-in-presubmit-test-script branch from abfc572 to 8ac04de Compare August 30, 2019 00:07
@k8s-ci-robot k8s-ci-robot removed the lgtm label Aug 30, 2019
@Ark-kun
Copy link
Contributor Author

Ark-kun commented Aug 30, 2019

@Bobgy @IronPan I've fixed the postsubmit test issue.

@IronPan
Copy link
Member

IronPan commented Aug 30, 2019

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: IronPan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 3962032 into kubeflow:master Aug 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants