add reference name to resource reference API proto #1781
Conversation
|
/assign @hongye-sun |
|
/lgtm |
|
/approve |
|
/retest |
|
/test kubeflow-pipeline-sample-test |
|
/lgtm |
|
/retest |
| @@ -27,6 +27,9 @@ type ResourceReference struct { | |||
| // The ID of the resource that been referenced to. | |||
| ReferenceUUID string `gorm:"column:ReferenceUUID; not null; "` | |||
|
|
|||
| // The name of the resource that been referenced to. | |||
| ReferenceName string `gorm:"column:ReferenceName; not null; "` | |||
There was a problem hiding this comment.
Adding a new required field usually breaks backwards compatibility with all existing clients.
What do you think about keeping it optional?
There was a problem hiding this comment.
This is database schema requirement which won't be surfaced through UI. Please see integration tests for the sample request.
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: IronPan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
|
/lgtm |
|
/test kubeflow-pipeline-e2e-test |
|
Verified the travis tests passed. only coverall failed. |
| @@ -30,7 +30,7 @@ | |||
| 'google-auth>=1.6.1', | |||
| 'requests_toolbelt>=0.8.0', | |||
| 'cloudpickle', | |||
| 'kfp-server-api >= 0.1.18, < 0.1.19', #Update the upper version whenever a new version of the kfp-server-api package is released. Update the lower version when there is a breaking change in kfp-server-api. | |||
| 'kfp-server-api >= 0.1.18, <= 0.1.25', #Update the upper version whenever a new version of the kfp-server-api package is released. Update the lower version when there is a breaking change in kfp-server-api. | |||
There was a problem hiding this comment.
It should be < 0.1.26 so that we can release fix versions like 0.1.25.1.
fix #1773
This change is