Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Surfacing resource name along with resource ID for referenced resources #1773

Closed
IronPan opened this issue Aug 8, 2019 · 10 comments · Fixed by #1781
Closed

Surfacing resource name along with resource ID for referenced resources #1773

IronPan opened this issue Aug 8, 2019 · 10 comments · Fixed by #1781

Comments

@IronPan
Copy link
Member

IronPan commented Aug 8, 2019

Currently UI spams the backend API server for getting the reference name for displaying in the UI.

Once we store and propagate the name of the reference along side the id, the UI no longer need to send those requests. This also reduce the API and DB load

@IronPan
Copy link
Member Author

IronPan commented Aug 9, 2019

#1781 surfaced the information to the API.
We still need to change UI to use the new field in API.

@IronPan IronPan changed the title Storing reference name in resource reference Surfacing resource name along with resource ID for referenced resources Aug 13, 2019
@IronPan
Copy link
Member Author

IronPan commented Aug 13, 2019

We also need to surface the pipeline name for pipeline IDs in here
https://github.com/kubeflow/pipelines/blob/master/backend/api/pipeline_spec.proto#L24

@Bobgy
Copy link
Contributor

Bobgy commented Aug 13, 2019

@IronPan Is this fully resolved?

I thought there were still UI parts left. @jessiezcc assigned that part of fix to me as a starter issue on UI.

@IronPan IronPan reopened this Aug 13, 2019
@IronPan
Copy link
Member Author

IronPan commented Aug 13, 2019

@Bobgy Yeah closed by accident. This is still needed.

@Bobgy
Copy link
Contributor

Bobgy commented Aug 16, 2019

/assign @ajchili

@Bobgy
Copy link
Contributor

Bobgy commented Aug 16, 2019

Let's close this

@ajchili
Copy link
Member

ajchili commented Aug 16, 2019

@Bobgy I do not have the permissions to close issues.

@Bobgy
Copy link
Contributor

Bobgy commented Aug 16, 2019

np, @IronPan can you close this issue?

@ajchili
Copy link
Member

ajchili commented Aug 28, 2019

/close
Feature has been added.

@k8s-ci-robot
Copy link
Contributor

@ajchili: Closing this issue.

In response to this:

/close
Feature has been added.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment