OpenVINO model optimizer component and example pipeline #178

dtrawins · 2018-11-09T20:23:51Z

This change is

googlebot · 2018-11-09T20:23:55Z

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.

What to do if you already signed the CLA

Individual signers

It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.

Corporate signers

Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
The email used to register you as an authorized contributor must also be attached to your GitHub account.

k8s-ci-robot · 2018-11-09T20:24:04Z

Hi @dtrawins. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot · 2018-11-09T20:24:04Z

Hi @dtrawins. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

coveralls · 2018-11-09T20:33:28Z

Pull Request Test Coverage Report for Build 152

0 of 0 changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 67.592%

Totals
Change from base Build 151:	0.0%
Covered Lines:	1535
Relevant Lines:	2179

💛 - Coveralls

vicaire · 2018-11-10T02:47:55Z

Hi @dtrawins,

The comments from one of the robots above provide details instructions on how to pass the CLA check.

See the comment starting with:

"Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA)."

Thanks!

dtrawins · 2018-11-13T21:54:23Z

I should be now in the required CLA group. Could you revalidate it now?

googlebot · 2018-11-13T21:54:25Z

CLAs look good, thanks!

vicaire

This looks good to me. Could you please just move the component to /contrib/components/openvino

Thanks!

vicaire · 2018-11-16T03:21:15Z

components/openvino/model_convert/README.md

@@ -0,0 +1,268 @@
+# Model optimization component


Would it be possible to move the code to /contrib/components/openvino?

sure, moved according to this suggestion

vicaire · 2018-11-16T20:57:29Z

/retest

vicaire

Hi, there seems to be two more files in the /sample directory, could we move them to the /contrib directory? Thanks!

vicaire · 2018-11-16T21:00:05Z

samples/openvino/model_optimizer/README.md

+This is an example of a one step pipeline implementation of model optimization using OpenVINO toolkit
+
+It performs graph optimization and generates Intermediate Representation model format which can be used 
+later by the Inference Engine. 


This file is still in the /samples directory. Could we move it to the /contrib directory?

samples are now also moved to contrib

vicaire · 2018-11-16T21:00:10Z

samples/openvino/model_optimizer/convert_model_pipeline.py

@@ -0,0 +1,28 @@
+
+import kfp.dsl as dsl


This file is still in the /samples directory. Could we move it to the /contrib directory?

samples are now also moved to contrib

vicaire · 2018-11-16T23:53:01Z

/lgtm
/approve

k8s-ci-robot · 2018-11-16T23:53:04Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vicaire

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [vicaire]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot · 2018-11-16T23:53:04Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vicaire

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [vicaire]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

vicaire · 2018-11-16T23:55:10Z

Bypassing the e2e tests since they are not affected by these changes.

k8s-ci-robot · 2018-11-16T23:59:08Z

@dtrawins: The following tests failed, say /retest to rerun them all:

Test name	Commit	Details	Rerun command
build-image	`11d8dac`	link	`/test build-image`
presubmit-unit-test	`11d8dac`	link	`/test presubmit-unit-test`

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

* We want to set the resource type to container because we are interested in container logs.

* Add developer guide * Add TF protos * Update Developer Guide with env vars * Change dir name for generated TF protos * Generate protos in tmp instead of vendor

* Remove randomness from condition example * Add forced results instead of completely removing randomness * Fix lint errors * Fix unit test

Merge v1.4.1 to Stable

OpenVINO model optimizer component and example pipeline

6b4400b

k8s-ci-robot requested review from Ark-kun and qimingj November 9, 2018 20:23

k8s-ci-robot requested a review from gaoning777 November 9, 2018 20:23

k8s-ci-robot added size/L labels Nov 9, 2018

k8s-ci-robot added the needs-ok-to-test label Nov 9, 2018

vicaire suggested changes Nov 16, 2018

View reviewed changes

component moved to contrib folder

a6de336

vicaire suggested changes Nov 16, 2018

View reviewed changes

moved samples to contrib

11d8dac

k8s-ci-robot assigned vicaire Nov 16, 2018

k8s-ci-robot added lgtm labels Nov 16, 2018

k8s-ci-robot added the approved label Nov 16, 2018

vicaire merged commit ce67707 into kubeflow:master Nov 16, 2018

Linchin pushed a commit to Linchin/pipelines that referenced this pull request Apr 11, 2023

Fix the stackdriver link. (kubeflow#178)

bfd4fb6

* We want to set the resource type to container because we are interested in container logs.

HumairAK added a commit to red-hat-data-services/data-science-pipelines that referenced this pull request Mar 11, 2024

Merge pull request kubeflow#178 from HumairAK/stable

54554bb

Merge v1.4.1 to Stable

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

OpenVINO model optimizer component and example pipeline #178

OpenVINO model optimizer component and example pipeline #178

dtrawins commented Nov 9, 2018 •

edited by jlewi

Loading

googlebot commented Nov 9, 2018

k8s-ci-robot commented Nov 9, 2018

k8s-ci-robot commented Nov 9, 2018

coveralls commented Nov 9, 2018 •

edited

Loading

vicaire commented Nov 10, 2018

dtrawins commented Nov 13, 2018

googlebot commented Nov 13, 2018

vicaire left a comment

vicaire Nov 16, 2018

dtrawins Nov 16, 2018

vicaire commented Nov 16, 2018

vicaire left a comment

vicaire Nov 16, 2018

dtrawins Nov 16, 2018

vicaire Nov 16, 2018

dtrawins Nov 16, 2018

vicaire commented Nov 16, 2018

k8s-ci-robot commented Nov 16, 2018

k8s-ci-robot commented Nov 16, 2018

vicaire commented Nov 16, 2018

k8s-ci-robot commented Nov 16, 2018

OpenVINO model optimizer component and example pipeline #178

OpenVINO model optimizer component and example pipeline #178

Conversation

dtrawins commented Nov 9, 2018 • edited by jlewi Loading

googlebot commented Nov 9, 2018

What to do if you already signed the CLA

Individual signers

Corporate signers

k8s-ci-robot commented Nov 9, 2018

k8s-ci-robot commented Nov 9, 2018

coveralls commented Nov 9, 2018 • edited Loading

Pull Request Test Coverage Report for Build 152

💛 - Coveralls

vicaire commented Nov 10, 2018

dtrawins commented Nov 13, 2018

googlebot commented Nov 13, 2018

vicaire left a comment

Choose a reason for hiding this comment

vicaire Nov 16, 2018

Choose a reason for hiding this comment

dtrawins Nov 16, 2018

Choose a reason for hiding this comment

vicaire commented Nov 16, 2018

vicaire left a comment

Choose a reason for hiding this comment

vicaire Nov 16, 2018

Choose a reason for hiding this comment

dtrawins Nov 16, 2018

Choose a reason for hiding this comment

vicaire Nov 16, 2018

Choose a reason for hiding this comment

dtrawins Nov 16, 2018

Choose a reason for hiding this comment

vicaire commented Nov 16, 2018

k8s-ci-robot commented Nov 16, 2018

k8s-ci-robot commented Nov 16, 2018

vicaire commented Nov 16, 2018

k8s-ci-robot commented Nov 16, 2018

dtrawins commented Nov 9, 2018 •

edited by jlewi

Loading

coveralls commented Nov 9, 2018 •

edited

Loading