Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add code for python visualization service #1651
Add code for python visualization service #1651
Changes from 31 commits
6c8c64d
d3f69d0
b66430a
b42d993
6d51c38
eedf87b
0ff333f
45d31ca
bf3f8d5
c091270
ccdbffa
51efcf5
c8d0457
525c5ad
4df0647
eaa931c
12fa85e
6fe1945
676bf84
d991c85
9dea2fd
a7afd7b
394d4c3
0166a3f
1d1da83
930c200
e3cf115
5aaad87
1ba7155
2fa67c9
9fec259
f1414c0
7629618
17a2bc2
d09a3d1
5320a0f
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: extra whitespace
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did not add due to PEP8 complaining about additional whitespace.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
check out
__file__
rather than cwd.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That would require the usage of
PurePath.parent
to determine the parent route of the file, is that ideal for this?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's ok to start with copying the pipeline component code in here. Sometime in the future, we should generalize this code for better reusability. e.g. expose the same interface as scikit learn roc_curve interface.