Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add code for python visualization service #1651

Merged
merged 36 commits into from
Aug 1, 2019
Merged

Add code for python visualization service #1651

merged 36 commits into from
Aug 1, 2019

Commits on Jul 22, 2019

  1. Setup initial server with roc_curve visualization

    @ajchili
    ajchili committed Jul 22, 2019
    Configuration menu
    Copy the full SHA
    6c8c64d View commit details
    Browse the repository at this point in the history

  2. Created Dockerfile.visualization

    @ajchili
    ajchili committed Jul 22, 2019
    Configuration menu
    Copy the full SHA
    d3f69d0 View commit details
    Browse the repository at this point in the history

  3. Fixed import issue

    @ajchili
    ajchili committed Jul 22, 2019
    Configuration menu
    Copy the full SHA
    b66430a View commit details
    Browse the repository at this point in the history

  4. Changed implementation of generate_html_from_notebook to allow templa… 

    …te type to be specified
    @ajchili
    ajchili committed Jul 22, 2019
    Configuration menu
    Copy the full SHA
    b42d993 View commit details
    Browse the repository at this point in the history

  5. Added tfdv.py

    @ajchili
    ajchili committed Jul 22, 2019
    Configuration menu
    Copy the full SHA
    6d51c38 View commit details
    Browse the repository at this point in the history

  6. Added unit tests for exporter.py

    @ajchili
    ajchili committed Jul 22, 2019
    Configuration menu
    Copy the full SHA
    eedf87b View commit details
    Browse the repository at this point in the history

  7. Deleted __init__.py

    @ajchili
    ajchili committed Jul 22, 2019
    Configuration menu
    Copy the full SHA
    0ff333f View commit details
    Browse the repository at this point in the history

  8. visualizations/ -> visualization/

    @ajchili
    ajchili committed Jul 22, 2019
    Configuration menu
    Copy the full SHA
    45d31ca View commit details
    Browse the repository at this point in the history

  9. Added requirements.txt and updated Dockerfile.visualization to use it

    @ajchili
    ajchili committed Jul 22, 2019
    Configuration menu
    Copy the full SHA
    bf3f8d5 View commit details
    Browse the repository at this point in the history

  10. Updated .travis.yml to run python visualization unit tests

    @ajchili
    ajchili committed Jul 22, 2019
    Configuration menu
    Copy the full SHA
    c091270 View commit details
    Browse the repository at this point in the history

  11. Fixed travis file path issue

    @ajchili
    ajchili committed Jul 22, 2019
    Configuration menu
    Copy the full SHA
    ccdbffa View commit details
    Browse the repository at this point in the history

Commits on Jul 23, 2019

  1. Continued testing to fix travis test issues

    @ajchili
    ajchili committed Jul 23, 2019
    Configuration menu
    Copy the full SHA
    51efcf5 View commit details
    Browse the repository at this point in the history

  2. Removed jupyter from pip3 install 

    Previously included to ensure python3 kernel was accessible to jupyter_client.
    @ajchili
    ajchili committed Jul 23, 2019
    Configuration menu
    Copy the full SHA
    c8d0457 View commit details
    Browse the repository at this point in the history

  3. Updated requirements.txt to included ipykernel

    @ajchili
    ajchili committed Jul 23, 2019
    Configuration menu
    Copy the full SHA
    525c5ad View commit details
    Browse the repository at this point in the history

  4. Removed maxDiff limit for all python tests

    @ajchili
    ajchili committed Jul 23, 2019
    Configuration menu
    Copy the full SHA
    4df0647 View commit details
    Browse the repository at this point in the history

  5. Sorted keys within args dictionary to ensure tests do not fail due to… 

    … dictionary order
    @ajchili
    ajchili committed Jul 23, 2019
    Configuration menu
    Copy the full SHA
    eaa931c View commit details
    Browse the repository at this point in the history

  6. Created requirements-test.txt

    @ajchili
    ajchili committed Jul 23, 2019
    Configuration menu
    Copy the full SHA
    12fa85e View commit details
    Browse the repository at this point in the history

  7. Added input_path argument support for python service 

    Also adds check for missing input_path argument and returns 400 error if argument is missing.
    @ajchili
    ajchili committed Jul 23, 2019
    Configuration menu
    Copy the full SHA
    6fe1945 View commit details
    Browse the repository at this point in the history

  8. Updated Copyright in Dockerfile.visualization

    @ajchili
    ajchili committed Jul 23, 2019
    Configuration menu
    Copy the full SHA
    676bf84 View commit details
    Browse the repository at this point in the history

  9. Updated snapshot to include all tests

    @ajchili
    ajchili committed Jul 23, 2019
    Configuration menu
    Copy the full SHA
    d991c85 View commit details
    Browse the repository at this point in the history

  10. Added types, additional comments, and TemplateType enum 

    Also made additional style changes
    @ajchili
    ajchili committed Jul 23, 2019
    Configuration menu
    Copy the full SHA
    9dea2fd View commit details
    Browse the repository at this point in the history

Commits on Jul 29, 2019

  1. Formatted template files

    @ajchili
    ajchili committed Jul 29, 2019
    Configuration menu
    Copy the full SHA
    a7afd7b View commit details
    Browse the repository at this point in the history

  2. Addressed most feedback made by @kevinbache

    @ajchili
    ajchili committed Jul 29, 2019
    Configuration menu
    Copy the full SHA
    394d4c3 View commit details
    Browse the repository at this point in the history

  3. Revert "Formatted template files" 

    This reverts commit a7afd7b. This was done due to issues faced by the templating engine.
    @ajchili
    ajchili committed Jul 29, 2019
    Configuration menu
    Copy the full SHA
    0166a3f View commit details
    Browse the repository at this point in the history

Commits on Jul 30, 2019

  1. Fixed comment placement and switched os -> Path

    @ajchili
    ajchili committed Jul 30, 2019
    Configuration menu
    Copy the full SHA
    1d1da83 View commit details
    Browse the repository at this point in the history

  2. Changed way exporter is implemented to use importlib

    @ajchili
    ajchili committed Jul 30, 2019
    Configuration menu
    Copy the full SHA
    930c200 View commit details
    Browse the repository at this point in the history

  3. Reverted to str.format due to python comparability issue 

    Python 3.6 introduced support for f-stringsl, this results in the tests failing when run in a python 3.5 environment
    @ajchili
    ajchili committed Jul 30, 2019
    Configuration menu
    Copy the full SHA
    e3cf115 View commit details
    Browse the repository at this point in the history

  4. Added unit tests for tornado web server

    @ajchili
    ajchili committed Jul 30, 2019
    Configuration menu
    Copy the full SHA
    5aaad87 View commit details
    Browse the repository at this point in the history

  5. Added license script for open source compliance

    @ajchili
    ajchili committed Jul 30, 2019
    Configuration menu
    Copy the full SHA
    1ba7155 View commit details
    Browse the repository at this point in the history

  6. Added line between file comment and license to match exporter.py

    @ajchili
    ajchili committed Jul 30, 2019
    Configuration menu
    Copy the full SHA
    2fa67c9 View commit details
    Browse the repository at this point in the history

  7. Updated server structure 

    * Created Exporter class
* Introduced ability to specify visualization timeout (default is 100 seconds)
* Added more comments
* Broke up post function in VisualizationHandler to call multiple function rather than handling all logic within post function
* Updated imports
* Updated tests
    @ajchili
    ajchili committed Jul 30, 2019
    Configuration menu
    Copy the full SHA
    9fec259 View commit details
    Browse the repository at this point in the history

Commits on Jul 31, 2019

  1. Addressed additional feedback from @kevinbache

    @ajchili
    ajchili committed Jul 31, 2019
    Configuration menu
    Copy the full SHA
    f1414c0 View commit details
    Browse the repository at this point in the history

  2. Fixed snapshot for test_exporter

    @ajchili
    ajchili committed Jul 31, 2019
    Configuration menu
    Copy the full SHA
    7629618 View commit details
    Browse the repository at this point in the history

  3. Comments -> Docstring Comments and other small fixes 

    * Fixed missing and incorrect typings
* shutdown_kernel is now private method of Exporter class
    @ajchili
    ajchili committed Jul 31, 2019
    Configuration menu
    Copy the full SHA
    17a2bc2 View commit details
    Browse the repository at this point in the history

  4. Added missing and updated docstring comments in server.py

    @ajchili
    ajchili committed Jul 31, 2019
    Configuration menu
    Copy the full SHA
    d09a3d1 View commit details
    Browse the repository at this point in the history

Commits on Aug 1, 2019

  1. Resolved latency issue with visualization server 

    Issue stemmed from a recreation of an exporter object per request, this was resolved by creating a global exporter.
    @ajchili
    ajchili committed Aug 1, 2019
    Configuration menu
    Copy the full SHA
    5320a0f View commit details
    Browse the repository at this point in the history