Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allows uploading a pipeline in new run form #1643

Merged

Conversation

rileyjbauer
Copy link
Contributor

@rileyjbauer rileyjbauer commented Jul 18, 2019

Fixes #52


This change is Reviewable

@Bobgy
Copy link
Contributor

Bobgy commented Oct 17, 2019

/retest

@Bobgy
Copy link
Contributor

Bobgy commented Oct 17, 2019

/assign @Bobgy

@Bobgy
Copy link
Contributor

Bobgy commented Oct 17, 2019

I tried the branch, it looks good to me.
Demo: https://drive.google.com/file/d/1_o4FO0IvIzGBoxo6Jy5uieUkqIL0n8LQ/view

@Bobgy
Copy link
Contributor

Bobgy commented Oct 17, 2019

Thanks @rileyjbauer, code looks great too.

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Bobgy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Bobgy
Copy link
Contributor

Bobgy commented Oct 17, 2019

/test kubeflow-pipeline-e2e-test

@k8s-ci-robot k8s-ci-robot merged commit 9ddf4c4 into kubeflow:master Oct 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

User should be able to upload a new pipeline when creating a new run.
6 participants