Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update persistent agence to only store the argo spec #1634

Merged
merged 6 commits into from
Jul 22, 2019
Merged

update persistent agence to only store the argo spec #1634

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
787c20d
update persistent agence to only store the argo spec
IronPan Jul 17, 2019
4eb308b
Update workflow_test.go
IronPan Jul 18, 2019
e83ce60
Update workflow.go
IronPan Jul 18, 2019
244f0e1
Update resource_manager_test.go
IronPan Jul 22, 2019
b4ec3f3
Update resource_manager.go
IronPan Jul 22, 2019
2f1c0ca
Update workflow_test.go
IronPan Jul 22, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update workflow.go
  • Loading branch information
@IronPan
IronPan committed Jul 18, 2019
commit e83ce60f29e33c4a092f76f0bfb3f7507858914f
2 changes: 1 addition & 1 deletion backend/src/common/util/workflow.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -161,7 +161,7 @@ func (w *Workflow) HasScheduledWorkflowAsParent() bool {
return containsScheduledWorkflow(w.Workflow.OwnerReferences)
}

func (w *Workflow) GetSpec() *Workflow {
func (w *Workflow) GetWorkflowSpec() *Workflow {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to update the references to this in resource_manager.go and resource_manager_test.go

workflow := w.DeepCopy()
workflow.Status = workflowapi.WorkflowStatus{}
workflow.TypeMeta = metav1.TypeMeta{Kind: w.Kind, APIVersion: w.APIVersion}
Expand Down