update persistent agence to only store the argo spec #1634
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently when persisting the runs spawned from a job, PersistentAgent stores more information than needed into the pipeline manifest, and also miss the TypeMetadata. This resulted in storing lots of runtime information that's not needed.
Example WorkflowSpec
```
"metadata":{
"name":"fffpw4fh-2-2911767673",
"namespace":"kubeflow",
"selfLink":"/apis/argoproj.io/v1alpha1/namespaces/kubeflow/workflows/fffpw4fh-2-2911767673",
"uid":"de23bd5c-a8c1-11e9-a176-42010a800233",
"resourceVersion":"3975687",
"generation":1,
"creationTimestamp":"2019-07-17T18:37:02Z",
"labels":{
"scheduledworkflows.kubeflow.org/isOwnedByScheduledWorkflow":"true",
"scheduledworkflows.kubeflow.org/scheduledWorkflowName":"fffpw4fh",
"scheduledworkflows.kubeflow.org/workflowEpoch":"1563388612",
"scheduledworkflows.kubeflow.org/workflowIndex":"2",
"workflows.argoproj.io/phase":"Running"
},
"ownerReferences":[
{
"apiVersion":"kubeflow.org/v1beta1",
"kind":"ScheduledWorkflow",
"name":"fffpw4fh",
"uid":"91039a28-a8c1-11e9-a176-42010a800233",
"controller":true,
"blockOwnerDeletion":true
}
]
},
```
|
/assign @rileyjbauer |
rileyjbauer
reviewed
Jul 17, 2019
backend/src/common/util/workflow.go
Outdated
| @@ -162,9 +162,11 @@ func (w *Workflow) HasScheduledWorkflowAsParent() bool { | |||
| } | |||
|
|
|||
| func (w *Workflow) GetSpec() *Workflow { | |||
There was a problem hiding this comment.
Can you rename this function as well, since it's returning the whole workflow, not just the spec
There was a problem hiding this comment.
done. hopefully getworkflowspec can reduce the confusion.
rileyjbauer
reviewed
Jul 22, 2019
| spec := w.DeepCopy() | ||
| spec.Status = workflowapi.WorkflowStatus{} | ||
| return NewWorkflow(spec) | ||
| func (w *Workflow) GetWorkflowSpec() *Workflow { |
There was a problem hiding this comment.
You need to update the references to this in resource_manager.go and resource_manager_test.go
|
Thanks for this! |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: IronPan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently when persisting the runs spawned from a job, PersistentAgent stores more information than needed into the pipeline manifest, and also miss the TypeMetadata. This resulted in storing lots of runtime information that's not needed.
Example WorkflowSpec
This change is