Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

activate public prow service account #153

Merged
merged 13 commits into from
Nov 9, 2018
Merged

activate public prow service account #153

merged 13 commits into from
Nov 9, 2018

Conversation

IronPan
Copy link
Member

@IronPan IronPan commented Nov 8, 2018

This change is Reviewable

@IronPan
Copy link
Member Author

IronPan commented Nov 8, 2018

/assign @Ark-kun

@k8s-ci-robot k8s-ci-robot assigned Ark-kun and unassigned Ark-kun Nov 8, 2018
@@ -33,6 +33,9 @@ instance_name=${instance_name:-test-minikube-${PULL_PULL_SHA:0:6}-$(date +%s)-$(

firewall_rule_name=allow-prow-ssh-$instance_name

# activating the service account
gcloud auth activate-service-account --key-file=${GOOGLE_APPLICATION_CREDENTIALS}
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would quote the variables, also let's see if presubmit passes

@IronPan
Copy link
Member Author

IronPan commented Nov 8, 2018

/retest

@IronPan
Copy link
Member Author

IronPan commented Nov 8, 2018

/test build-image

@IronPan
Copy link
Member Author

IronPan commented Nov 8, 2018

/test presubmit-unit-test

@krzyzacy
Copy link

krzyzacy commented Nov 8, 2018

(probably takes a while to populate...)

@IronPan
Copy link
Member Author

IronPan commented Nov 8, 2018

/test build-image

@IronPan
Copy link
Member Author

IronPan commented Nov 8, 2018

/test build-image

@IronPan
Copy link
Member Author

IronPan commented Nov 8, 2018

/test presubmit-unit-test

@IronPan
Copy link
Member Author

IronPan commented Nov 8, 2018

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: IronPan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

1 similar comment
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: IronPan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Ark-kun
Copy link
Contributor

Ark-kun commented Nov 8, 2018

/lgtm

@k8s-ci-robot k8s-ci-robot merged commit a855ffb into master Nov 9, 2018
Ark-kun pushed a commit that referenced this pull request Nov 9, 2018
* activate service account

* Update presubmit-tests-gce-minikube.sh

* Update presubmit-tests.gke.sh

* Update presubmit-tests.sh

* update git clone

* update image

* update image

* Removed the SSH key copying

* update git clone

* update image

* update
@IronPan IronPan deleted the yangpa/sa branch December 10, 2018 22:26
Linchin pushed a commit to Linchin/pipelines that referenced this pull request Apr 11, 2023
* Check if status and phase is set in argo workflow crd

Sometimes it takes a while for the argo controller to populate
the status field of an object.

Fixes kubeflow/testing#147

* Update

* Update
magdalenakuhn17 pushed a commit to magdalenakuhn17/pipelines that referenced this pull request Oct 22, 2023
* initial pytorch support

* modifying go crd files

* modifying go crd files

* test placeholder

* cleaning up test placeholder file

* updating with cifar10 sample

* updating cifar10 instructions

* correcting docker steps

* adding pytorch doeckerfile

* removing generated data files

* correcting the sample pytorch yaml file

* adding the class file and class name parameters

* adding cifar10 input file and dockerfile

* adding gcs location for model file

* addressing review comments

* simplifying PyTorch interface

* making model class name optional

* fix the comment ordering

* removing model file

* adding default behaviour
HumairAK pushed a commit to red-hat-data-services/data-science-pipelines that referenced this pull request Mar 11, 2024
* updated compiler

* update the tests

* Update affinity.yaml

* Update compiler.py

* Update compiler.py

* Update affinity.yaml

Put back the license.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants