Check if status and phase is set in argo workflow crd (kubeflow#153)

* Check if status and phase is set in argo workflow crd Sometimes it takes a while for the argo controller to populate the status field of an object. Fixes kubeflow/testing#147 * Update * Update
Linchin · Jun 8, 2018 · e915ec0 · e915ec0
1 parent 2b2d8a1
commit e915ec0
Showing 1 changed file with 3 additions and 1 deletion.
diff --git a/py/kubeflow/testing/argo_client.py b/py/kubeflow/testing/argo_client.py
@@ -66,7 +66,9 @@ def wait_for_workflows(client, namespace, names,
 
     done = True
     for results in all_results:
-      if results["status"]["phase"] not in ["Failed", "Succeeded"]:
+      # Sometimes it takes a while for the argo controller to populate
+      # the status field of an object.
+      if results.get("status", {}).get("phase", "") not in ["Failed", "Succeeded"]:
         done = False
 
     if done: