Adds metrics table to Compare page, creates Metric component #1284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rileyjbauer
changed the title
rileyjbauer
changed the title
hongye-sun
reviewed
May 16, 2019
There was a problem hiding this comment.
The metrics extraction code looks good to me. @rileyjbauer, you probably need someone else to review the FE code.
/lgtm
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rileyjbauer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
magdalenakuhn17
pushed a commit
to magdalenakuhn17/pipelines
that referenced
this pull request
Oct 22, 2023
…ructions (kubeflow#1284) * workaround for kustomize bug * removing the troublesome namespace field altogether
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
CompareTableis not sortable, which is not ideal for metrics. However, this isn't much of a problem if the number of runs being compared is small.If we do want a sortable table, we'll have to decide if we want to build one that can sort along rows (rather than columns), or if we want to transpose the parameters and metrics tables on the compare page.
Fixes: #468
Initial table will look like this:
This change is