Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consolidate UI of toolbars for AllRunsList and ExperimentList #124

Merged
merged 2 commits into from
Nov 8, 2018

Conversation

rileyjbauer
Copy link
Contributor

@rileyjbauer rileyjbauer commented Nov 7, 2018

Fixes: #71

Keeps Experiments button/tab on the side-nav highlighted for all non-pipeline pages, including RecurringRunDetails and Compare.

Changes the title on the AllRunsList page to match that of the ExperimentList page and adds Create new experiment button to AllRunsList

Note that we probably should truly merge these pages at some point.


This change is Reviewable

Copy link
Contributor

@yebrahim yebrahim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

frontend/src/components/SideNav.tsx Outdated Show resolved Hide resolved
frontend/src/components/SideNav.tsx Show resolved Hide resolved
@yebrahim yebrahim changed the title Consolidate UI of toolbars for AllRunsList and ExperimentList [WIP] Consolidate UI of toolbars for AllRunsList and ExperimentList Nov 7, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: yebrahim

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rileyjbauer
Copy link
Contributor Author

/retest

@yebrahim
Copy link
Contributor

yebrahim commented Nov 8, 2018

/lgtm

@yebrahim yebrahim changed the title [WIP] Consolidate UI of toolbars for AllRunsList and ExperimentList Consolidate UI of toolbars for AllRunsList and ExperimentList Nov 8, 2018
@k8s-ci-robot k8s-ci-robot merged commit b782e5f into master Nov 8, 2018
@rileyjbauer rileyjbauer deleted the make-allruns-and-experimentlist-uniform branch November 12, 2018 17:50
magdalenakuhn17 pushed a commit to magdalenakuhn17/pipelines that referenced this pull request Oct 22, 2023
HumairAK pushed a commit to red-hat-data-services/data-science-pipelines that referenced this pull request Mar 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants