Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Experiment list title should not change #71

Closed
ajayalfred opened this issue Nov 6, 2018 · 3 comments
Closed

Experiment list title should not change #71

ajayalfred opened this issue Nov 6, 2018 · 3 comments

Comments

@ajayalfred
Copy link
Contributor

When switching between the "Experiments" and "Runs" tab, the page title is changing and the "Create experiment" button is hidden. This is incorrect, the title and actions above tabs should not change based on tab selection since it breaks the design system rules.

Also, the Experiments link in the nav must remain highlighted as long as the user is in that section.

screen shot 2018-11-05 at 4 47 53 pm

screen shot 2018-11-05 at 4 48 53 pm

@rileyjbauer
Copy link
Contributor

I agree with what you said, but I have a question:
When a user navigates between the tabs, should any state be retained? for example, should selected runs from one tab stay selected if the user navigates to the other tab? that could be useful for finding runs, but it could also be surprising if we have no indication of what is selected.

Along those lines but less importantly, what about things like list page [size], list sorting, etc. ?

@ajayalfred
Copy link
Contributor Author

If the component supports it, then you can preserve selection between list page changes.

Remembering selection between tabs is non-standard behavior, GCP doesn't use this pattern. I also don't see a usecase for a user trying to select runs between the two tabs, because each tab already contains all runs (one is grouped by experiment, the other isn't)

@ajayalfred
Copy link
Contributor Author

I think this is a P1 bug, please move up in priority. It feels broken esp. when the 'experiment' section in the nav becomes inactive

magdalenakuhn17 pushed a commit to magdalenakuhn17/pipelines that referenced this issue Oct 22, 2023
kubeflow#71)

* Added pod labels to RevisionTemplate specs and retooled configuration creation logic

* Addressed PR comments

* Fails image_patch if IMG can't be set

* Fixed a reference to kfserving-system namespace
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants