-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Experiment list title should not change #71
Comments
I agree with what you said, but I have a question: Along those lines but less importantly, what about things like list page [size], list sorting, etc. ? |
If the component supports it, then you can preserve selection between list page changes. Remembering selection between tabs is non-standard behavior, GCP doesn't use this pattern. I also don't see a usecase for a user trying to select runs between the two tabs, because each tab already contains all runs (one is grouped by experiment, the other isn't) |
I think this is a P1 bug, please move up in priority. It feels broken esp. when the 'experiment' section in the nav becomes inactive |
kubeflow#71) * Added pod labels to RevisionTemplate specs and retooled configuration creation logic * Addressed PR comments * Fails image_patch if IMG can't be set * Fixed a reference to kfserving-system namespace
When switching between the "Experiments" and "Runs" tab, the page title is changing and the "Create experiment" button is hidden. This is incorrect, the title and actions above tabs should not change based on tab selection since it breaks the design system rules.
Also, the Experiments link in the nav must remain highlighted as long as the user is in that section.
The text was updated successfully, but these errors were encountered: