Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release component image version a277f87ea1d4707bf860d080d06639b7caf9a1cf #1082

Merged
merged 2 commits into from
Apr 4, 2019

Conversation

neuromage
Copy link
Contributor

@neuromage neuromage commented Apr 4, 2019

/assign @IronPan


This change is Reviewable

Copy link
Contributor

@animeshsingh animeshsingh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@Ark-kun
Copy link
Contributor

Ark-kun commented Apr 4, 2019

You should probably re-run the script.

@k8s-ci-robot k8s-ci-robot added size/L and removed size/S labels Apr 4, 2019
@neuromage
Copy link
Contributor Author

@IronPan can you take a look please? Thanks!

@IronPan
Copy link
Member

IronPan commented Apr 4, 2019

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: IronPan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: IronPan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit f344301 into kubeflow:master Apr 4, 2019
magdalenakuhn17 pushed a commit to magdalenakuhn17/pipelines that referenced this pull request Oct 22, 2023
* kfserver add load/unload endpoint

* address comments

* revert license

* fix python packages bugs

* revert crd serving.kubeflow.org_inferenceservices

* add missing packages in setup.py

* update package import and trigger build/test

* revert back pytorchserver

* update

* fix sklearn docker

* fix model package init

* revert back sklearn/xgboost and add SKLearnModelRepository/XGBoostModelRepository

* remove unused file

* mount directory follows /mnt/models/

* remove unused files

* create storage destination dir if not exist

* model dir -> /mnt/models/

* fix unit test

* revert back model repo

* pass model dir to KFModelRepository

* move registered_models to the last on the argument list
HumairAK pushed a commit to red-hat-data-services/data-science-pipelines that referenced this pull request Mar 11, 2024
…kubeflow#1087)

* cheerypick(sdk): Fix counter param cherrypick (kubeflow#1080) (kubeflow#1082)

* fix nested loop counter param bug

* Update _tekton_handler.py

* fix inline spec for new features

* Update _tekton_handler.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants