Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid depending on port-forwarded ambassador service #1080

Closed
IronPan opened this issue Apr 4, 2019 · 11 comments
Closed

Avoid depending on port-forwarded ambassador service #1080

IronPan opened this issue Apr 4, 2019 · 11 comments

Comments

@IronPan
Copy link
Member

IronPan commented Apr 4, 2019

Kubeflow is moving away from ambassador, in favor of istio, and proxy the cluster using cloud endpoint with IAP or simple auth. In both cases, we should use the ingress endpoint instead of depending on port-forwarding to access the cluster.

@kevinbache
Copy link
Contributor

somewhat related: #1104, #780

@jlewi
Copy link
Contributor

jlewi commented Jun 4, 2019

@IronPan @vicaire How's this coming? Are you on track to have this ready for 0.6?

@IronPan
Copy link
Member Author

IronPan commented Jun 5, 2019

@jingzhang36 I remember you are working on istio integration. How is it going?
@jlewi Just to double check. I think we agreed that despite istio integration, we always leave user an option to not install istio, and can do port-forwarding. Is that something that still align with your thinking?

@jlewi
Copy link
Contributor

jlewi commented Jun 26, 2019

@IronPan I think we discussed this offline. ISTIO or a service mesh is a requirement. If users want to customize the ISTIO gateway config to disable auth to allow port-forwarding they can do that. This would require editing various config files to disable AuthZ at the ISTIO gateway.

@jlewi
Copy link
Contributor

jlewi commented Jun 26, 2019

@IronPan Is this done?

@IronPan
Copy link
Member Author

IronPan commented Jun 27, 2019

@jingzhang36 Do you have any update on this?
@hongye-sun I think we should do an evaluation on the kfp.client() when the 0.6 candidate is out. WDYT?
Let's not close this before both items above are done.

@jlewi
Copy link
Contributor

jlewi commented Jun 28, 2019

@IronPan @hongye-sun I would suggest trying out master as soon as possible to see if its working.

@jlewi
Copy link
Contributor

jlewi commented Jun 28, 2019

IAP should be working on master; basic auth seems to be having problems on master #3562

@jingzhang36
Copy link
Contributor

Regarding istio, I feel tensorboard /data hack is no longer blocking istio since #1237 is recently merged (and Gabriel's PR kubeflow/kubeflow#3036 is already in master). Are there any other things that need to be done to complete istio integration? E.g., remove old routing rules?

@jlewi
Copy link
Contributor

jlewi commented Jul 1, 2019

@IronPan Have you or someone else verified that the pipelines SDK works with IAP? I believe that was the original genesis of this issue. In particular the goal of this issue was to ensure the could connect via the secure public endpoint of KF to pipelines from outside the cluster.

/cc @jessiezcc

@IronPan
Copy link
Member Author

IronPan commented Jul 8, 2019

Verified the KFP client works well with a v0.6 KF cluster with IAP.
Here is a code snippet that can successfully create/list experiment

import kfp
client=kfp.Client(namespace="kubeflow")
exp=client.create_experiment(name="commandline")
client.list_experiments()

@IronPan IronPan closed this as completed Jul 8, 2019
HumairAK pushed a commit to red-hat-data-services/data-science-pipelines that referenced this issue Mar 11, 2024
* fix nested loop counter param bug

* address comments
HumairAK pushed a commit to red-hat-data-services/data-science-pipelines that referenced this issue Mar 11, 2024
…kubeflow#1087)

* cheerypick(sdk): Fix counter param cherrypick (kubeflow#1080) (kubeflow#1082)

* fix nested loop counter param bug

* Update _tekton_handler.py

* fix inline spec for new features

* Update _tekton_handler.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants