Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using stable versions of Bazel for the backend build #3461

Closed
Ark-kun opened this issue Apr 7, 2020 · 13 comments
Closed

Using stable versions of Bazel for the backend build #3461

Ark-kun opened this issue Apr 7, 2020 · 13 comments
Assignees
Labels
area/backend priority/p1 status/triaged Whether the issue has been explicitly triaged

Comments

@Ark-kun
Copy link
Contributor

Ark-kun commented Apr 7, 2020

Bazel is already at v3.0.0, but the backend seems to require pretty old version of Bazel (v0.23).
It would be great if the backend would successfully build using the stable supported version of Bazel.

@Bobgy
Copy link
Contributor

Bobgy commented Apr 15, 2020

/cc @rmgogogo @jingzhang36
I think we have an existing similar issue. Do you have any ideas?

@Bobgy Bobgy added the status/triaged Whether the issue has been explicitly triaged label Apr 15, 2020
@Ark-kun
Copy link
Contributor Author

Ark-kun commented Apr 19, 2020

Related: #3061

@Ark-kun
Copy link
Contributor Author

Ark-kun commented Apr 19, 2020

I've tried to upgrade the build rulez, bazel and gazelle. After fixing some issues, I think we'll also need to update the Kubernetes repositories and modules.

@Ark-kun
Copy link
Contributor Author

Ark-kun commented May 15, 2020

This is the branch where I tried to update the workplace: https://github.com/Ark-kun/pipelines/commits/Backend---Updated-BUILD-files-using-gazelle

@animeshsingh
Copy link
Contributor

@Ark-kun is there any other Bazel expert on KFP team side ? Having a harder time finding experts on our side, given bazel is very specific to Google - and it seems the current version being very old is blocking us to use Tekton Go modules, as @Tomcli outlined

@Ark-kun
Copy link
Contributor Author

Ark-kun commented May 15, 2020

KFP Backend build was converted to Bazel by @neuromage . I've assigned him to this issue.

@animeshsingh
Copy link
Contributor

Thanks @Ark-kun

@neuromage please see if you can get this unblocked at your end

@neuromage
Copy link
Contributor

/assign @Ark-kun

Unfortunately, I don't have cycles to look into this right now. Alexey, since you've already been looking into this, can you try and update our Bazel version and WORKSPACE files?

@animeshsingh @Tomcli we're happy to accept PRs here as well. Bazel is open sourced, and our knowledge is based around OSS-ed documentation, so there's no real advantage here. If there is a configuration that works to unblock your use-case for Tekton modules, we'd be happy to accept the change. Thanks!

/cc @jessiezcc
/cc @paveldournov

@neuromage
Copy link
Contributor

@Ark-kun I took a look at the code again, and it looks like Bazel is no longer required to build API server, since @dushyanthsc removed the MLMD dependency we previously had. I think you can make this a lot simpler by upgrading Bazel to just work for building the protos, and remove it from all other places. Since there is no longer a need to build the C++ dependency anymore, you can just use native Go for all other places in the backend.

/cc @IronPan
/cc @rmgogogo
to see if they have any objections to this plan.

@rmgogogo
Copy link
Contributor

@Ark-kun I took a look at the code again, and it looks like Bazel is no longer required to build API server, since @dushyanthsc removed the MLMD dependency we previously had. I think you can make this a lot simpler by upgrading Bazel to just work for building the protos, and remove it from all other places. Since there is no longer a need to build the C++ dependency anymore, you can just use native Go for all other places in the backend.

/cc @IronPan
/cc @rmgogogo
to see if they have any objections to this plan.

No problem. The major unblocker is removing the TensorFlow WORKSPACE dependency which is already be done before.

@stale
Copy link

stale bot commented Sep 4, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot unassigned jingzhang36 Sep 4, 2020
@stale stale bot added the lifecycle/stale The issue / pull request is stale, any activities remove this label. label Sep 4, 2020
@rmgogogo
Copy link
Contributor

rmgogogo commented Sep 9, 2020

@Bobgy as talked offline, we may remove Bazel, but use go mod for BE.

@stale stale bot removed the lifecycle/stale The issue / pull request is stale, any activities remove this label. label Sep 9, 2020
@Bobgy
Copy link
Contributor

Bobgy commented Oct 28, 2020

We've removed bazel, now we can close this

@Bobgy Bobgy closed this as completed Oct 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/backend priority/p1 status/triaged Whether the issue has been explicitly triaged
Projects
None yet
Development

No branches or pull requests

8 participants