-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Using stable versions of Bazel for the backend build #3461
Comments
/cc @rmgogogo @jingzhang36 |
Related: #3061 |
I've tried to upgrade the build rulez, bazel and gazelle. After fixing some issues, I think we'll also need to update the Kubernetes repositories and modules. |
This is the branch where I tried to update the workplace: https://github.com/Ark-kun/pipelines/commits/Backend---Updated-BUILD-files-using-gazelle |
KFP Backend build was converted to Bazel by @neuromage . I've assigned him to this issue. |
Thanks @Ark-kun @neuromage please see if you can get this unblocked at your end |
/assign @Ark-kun Unfortunately, I don't have cycles to look into this right now. Alexey, since you've already been looking into this, can you try and update our Bazel version and WORKSPACE files? @animeshsingh @Tomcli we're happy to accept PRs here as well. Bazel is open sourced, and our knowledge is based around OSS-ed documentation, so there's no real advantage here. If there is a configuration that works to unblock your use-case for Tekton modules, we'd be happy to accept the change. Thanks! /cc @jessiezcc |
@Ark-kun I took a look at the code again, and it looks like Bazel is no longer required to build API server, since @dushyanthsc removed the MLMD dependency we previously had. I think you can make this a lot simpler by upgrading Bazel to just work for building the protos, and remove it from all other places. Since there is no longer a need to build the C++ dependency anymore, you can just use native Go for all other places in the backend. /cc @IronPan |
No problem. The major unblocker is removing the TensorFlow WORKSPACE dependency which is already be done before. |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
@Bobgy as talked offline, we may remove Bazel, but use go mod for BE. |
We've removed bazel, now we can close this |
Bazel is already at v3.0.0, but the backend seems to require pretty old version of Bazel (v0.23).
It would be great if the backend would successfully build using the stable supported version of Bazel.
The text was updated successfully, but these errors were encountered: