Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

upgrade Bazel from 0.23 to 2.1 and remove TF from WORKSPACE #3061

Closed
rmgogogo opened this issue Feb 12, 2020 · 5 comments
Closed

upgrade Bazel from 0.23 to 2.1 and remove TF from WORKSPACE #3061

rmgogogo opened this issue Feb 12, 2020 · 5 comments
Assignees
@rmgogogo @jingzhang36
Labels
area/backend area/engprod priority/p1 status/triaged Whether the issue has been explicitly triaged

Comments

@rmgogogo
Copy link
Contributor

  1. we don't have direct source dependency on TF. Removing it from WORKSPACE make sense as it introduced a lot of others.

  2. upgrade Bazel from 0.23 to 2.1

  3. golang dependency file is not updated for a very long time. Since we use Docker builder more which will update it in run time but if we use Bazel, we will find many not up to date
@Ark-kun
Copy link
Contributor

Ark-kun commented Feb 13, 2020

we don't have direct source dependency on TF. Removing it from WORKSPACE make sense as it introduced a lot of others.

#2856

@rmgogogo
Copy link
Contributor Author

@jingzhang36 FYI.
Alexy's PR2856 would help a lot to simplify the bazel stuff.

@Ark-kun
Copy link
Contributor

Ark-kun commented Feb 13, 2020

Thanks. I'm not sure how to detect any other unused entries...

@Bobgy Bobgy added status/triaged Whether the issue has been explicitly triaged area/engprod labels Mar 4, 2020
@Bobgy
Copy link
Contributor

Bobgy commented Mar 4, 2020

@rmgogogo Can you assign a priority for this?

@rmgogogo rmgogogo mentioned this issue Mar 9, 2020
Merged
@rmgogogo
Copy link
Contributor Author

rmgogogo commented Mar 9, 2020

(1) is done by Alexy.
We can continue (2) and (3).

@jingzhang36 I can help upgrade the bazel version, here quickly ping you in case we have other blockers.

@Ark-kun Ark-kun mentioned this issue Apr 19, 2020
Closed
@Gsantomaggio Gsantomaggio mentioned this issue Jun 11, 2020
Closed
magdalenakuhn17 pushed a commit to magdalenakuhn17/pipelines that referenced this issue Oct 22, 2023
@andyi2it
Release v0.11.0 (kubeflow#3061)
c548640 
Signed-off-by: Andrews Arokiam <andrews.arokiam@ideas2it.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rmgogogo rmgogogo

@jingzhang36 jingzhang36

Labels
area/backend area/engprod priority/p1 status/triaged Whether the issue has been explicitly triaged
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@Ark-kun @rmgogogo @Bobgy @jingzhang36