-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Backend] pH - How to update dependency? #4307
Comments
TODO:
|
First of all, I believe the way we manage BE dependencies is no different from other golang projects who use bazel. In other words, there is nothing special to our dependency management and any online tutorial on managing golang projs with bazel applies to our project (the same as it applies to other golang projects with bazel) Second, if the dependency is broken or goes wrong, we'll have to follow the build errors and try to fix it. Personally, I don't know of any hack way that can quickly do that. But maybe @IronPan and @neuromage know of some quick fixes. Regarding #3965, I'll try to figure out why. |
If there are any existing doc that will be great, we can just put a link in the README.md |
The backend uses a really outdated version of Bazel. The build files are incompatible with stable Bazel versions and the build files of new versions of the dependencies are incompatible with the old Bazel version that we use. We might improve the developer productivity here by scaling back the usage of Bazel and going back to using Go modules. |
Yes, I totally agree with @Ark-kun. I feel the extra steps to use bazel is just unnecessary when go modules is already becoming golang standard. People contributing can possibly have good knowledge of go modules, but I don't feel enough people know how to use bazel. As Ajay mentioned, we may still keep bazel for building the proto for the moment. |
There are two issues here (let's try solving the one described in this issue's description first, without unnecessarily letting the other to be blocking).
|
Thanks for clarification! With https://github.com/kubeflow/pipelines/tree/master/backend#updating-build-files, I think this issue's purpose is already met. We can continue discussion of cleaning up bazel dep by upgrading/stopping to use it in #3461. |
#3965 has been blocked for nearly a month, because no one knows how to update backend dependencies properly.
We need clear documentation for instructions.
/assign @jingzhang36 @IronPan
/cc @NikeNano
The text was updated successfully, but these errors were encountered: