Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Embeddable run view page #182

Closed
Ark-kun opened this issue Nov 9, 2018 · 17 comments
Closed

Embeddable run view page #182

Ark-kun opened this issue Nov 9, 2018 · 17 comments
Assignees
Labels
area/frontend help wanted The community is welcome to contribute. kind/feature lifecycle/stale The issue / pull request is stale, any activities remove this label. priority/p2 status/triaged Whether the issue has been explicitly triaged

Comments

@Ark-kun
Copy link
Contributor

Ark-kun commented Nov 9, 2018

I'd like to insert the run view page into a notebook when I submit the run.

For this I'd like to have a minimal page without left or top navigation, with only the run view and the refresh button.

@yebrahim
Copy link
Contributor

yebrahim commented Nov 9, 2018

The run details page is one of the more complicated parts of the frontend. What's the use case for this?

@Ark-kun
Copy link
Contributor Author

Ark-kun commented Nov 9, 2018

The scenario is embedding the run view in the Notebook.
Submit the run and immediately see it in your notebook.

@yebrahim
Copy link
Contributor

But why? Assuming you're talking about a Jupyter notebook hosted from a Kubeflow cluster, why not just click a link to see the run in the Pipelines UI? Is the goal to save this click?

Or is the above assumption incorrect? Are you talking about a completely standalone notebook, with visualizations packaged into it?

@Ark-kun
Copy link
Contributor Author

Ark-kun commented Nov 12, 2018

But why? Assuming you're talking about a Jupyter notebook hosted from a Kubeflow cluster, why not just click a link to see the run in the Pipelines UI? Is the goal to save this click?

Yes. This is about saving a click each time you want to check the run. This is even more important when the user runs JupyterLab as a separate application and not as a browser tab.

@Ark-kun
Copy link
Contributor Author

Ark-kun commented Nov 12, 2018

Is it hard to add support for query parameter like hide_navigation=true ?

@yebrahim
Copy link
Contributor

Can you elaborate on the JupyterLab-as-separate-application part? Is it still backed by the KF cluster kernel manager?

This isn't about changing the view or removing the chrome, it's about hosting our entire UI webapp in the notebook's cell output iframe, and most importantly finding a way around CORS. If the only motive here is saving a single click, I don't see why we should pursue this.

@yebrahim
Copy link
Contributor

yebrahim commented Dec 4, 2018

I'll close this as I don't see a good reason for it, nor do I see a good way of doing it.
We can continue the discussion separately if you still feel a need for this.

@Bobgy
Copy link
Contributor

Bobgy commented Jan 16, 2020

Can you elaborate on the JupyterLab-as-separate-application part?

I also wanted clarification on this. What would be different in JupyterLab?

Does jupyter use an iframe to show KFP UI page? Did you try so? It should already show the UI, just with the navigation. If you already verified that works, this feature isn't very hard. Although I kind of doubt how many people actually wants it. Does the efforts worth saving a click?

@Bobgy Bobgy added the status/triaged Whether the issue has been explicitly triaged label Jan 22, 2020
@Ark-kun
Copy link
Contributor Author

Ark-kun commented Mar 11, 2020

Does jupyter use an iframe to show KFP UI page? Did you try so? It should already show the UI, just with the navigation.

As far as I remember, I've verified that Jupyter can show iframes with arbitrary pages. That IFrame has limited height by default, so the top navigation obscures most of it.

Although I kind of doubt how many people actually wants it. Does the efforts worth saving a click?

The idea is to be able to stay in the development environment (Jupyter) while monitoring the work progress. I think this will look pretty cool can unique for demos.

@stale
Copy link

stale bot commented Jun 24, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the lifecycle/stale The issue / pull request is stale, any activities remove this label. label Jun 24, 2020
@Bobgy
Copy link
Contributor

Bobgy commented Jun 24, 2020

I can follow up on a demo with this, shouldn't be too hard

@stale stale bot removed the lifecycle/stale The issue / pull request is stale, any activities remove this label. label Jun 24, 2020
@stale
Copy link

stale bot commented Sep 22, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the lifecycle/stale The issue / pull request is stale, any activities remove this label. label Sep 22, 2020
@Bobgy
Copy link
Contributor

Bobgy commented Sep 29, 2020

/frozen

@stale stale bot removed the lifecycle/stale The issue / pull request is stale, any activities remove this label. label Sep 29, 2020
@stale
Copy link

stale bot commented Dec 28, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the lifecycle/stale The issue / pull request is stale, any activities remove this label. label Dec 28, 2020
@Bobgy Bobgy added the help wanted The community is welcome to contribute. label Dec 30, 2020
@stale stale bot removed the lifecycle/stale The issue / pull request is stale, any activities remove this label. label Dec 30, 2020
@Bobgy
Copy link
Contributor

Bobgy commented Feb 19, 2021

/cc @Jamxl @StefanoFioravanzo
about this interesting request
but it's not a priorrity

@stale
Copy link

stale bot commented Jun 2, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the lifecycle/stale The issue / pull request is stale, any activities remove this label. label Jun 2, 2021
@stale
Copy link

stale bot commented Apr 29, 2022

This issue has been automatically closed because it has not had recent activity. Please comment "/reopen" to reopen it.

@stale stale bot closed this as completed Apr 29, 2022
magdalenakuhn17 pushed a commit to magdalenakuhn17/pipelines that referenced this issue Oct 22, 2023
* add Dockerfile for alibiexplainer

* fix missing quote on entrypoint args

* use python:3.7 base image for alibiexplainer
HumairAK pushed a commit to red-hat-data-services/data-science-pipelines that referenced this issue Mar 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/frontend help wanted The community is welcome to contribute. kind/feature lifecycle/stale The issue / pull request is stale, any activities remove this label. priority/p2 status/triaged Whether the issue has been explicitly triaged
Projects
None yet
Development

No branches or pull requests

3 participants