Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Render static graph when compiling a pipeline in a notebook #504

Closed
amygdala opened this issue Dec 8, 2018 · 16 comments
Closed

Render static graph when compiling a pipeline in a notebook #504

amygdala opened this issue Dec 8, 2018 · 16 comments
Assignees
Labels

Comments

@amygdala
Copy link
Contributor

amygdala commented Dec 8, 2018

Feature request: When compiling a pipeline in a notebook, render the static graph as output, same as the graph shown when you upload a pipeline.

@gaoning777
Copy link
Contributor

Why is the compiler generating a static graph important when we already have the pipeline UI supporting it? Would it be a common scenario that users author the pipeline without a pipeline deployment(we do support on-prem minikube) such that the DSL generating the static graph is beneficial? Thanks

@yebrahim
Copy link
Contributor

I can see that providing a nice feedback loop to iterate visually on the pipeline. You make a change, compile, see the output graph, then iterate. It's easier to debug high level issues just by looking at the graph than dozens of Python lines.

It won't be easy to support though, since the graph is built on the fly by our UI layer. It does make one more argument for enabling editing the pipeline source code in our UI though?
@Ark-kun @qimingj

@Ark-kun
Copy link
Contributor

Ark-kun commented Mar 15, 2019

Yes, visual pipeline editing would be great.

As for the graph, I could generate it, but I'm, a bit hesitant to add more dependencies (to graphing packages) to the SDK.

@Ark-kun
Copy link
Contributor

Ark-kun commented Mar 15, 2019

Another solution would be to add IFrame to Jupyter (easy - I've checked) that shows the run page (without navigation). See #182

@vicaire vicaire changed the title Feature request: render static graph as output when compiling a pipeline in notebook Render static graph when compiling a pipeline in a notebook May 31, 2019
@gaoning777 gaoning777 added the help wanted The community is welcome to contribute. label Jul 2, 2019
@gaoning777
Copy link
Contributor

@amygdala is this still a wanted feature?

@gaoning777
Copy link
Contributor

/unassign @gaoning777
/assign @numerology @Ark-kun

@k8s-ci-robot k8s-ci-robot assigned Ark-kun and numerology and unassigned gaoning777 Jan 9, 2020
@Ark-kun Ark-kun assigned Bobgy and unassigned Ark-kun Jan 16, 2020
@Bobgy
Copy link
Contributor

Bobgy commented Jan 16, 2020

This sounds useful. @Ark-kun Can you provide me an example python notebook that compiles a pipeline, uploads it and shows the iframe of pipeline detail page, so I can try to iterate UI on it.

@Bobgy Bobgy added the status/triaged Whether the issue has been explicitly triaged label Mar 6, 2020
@Bobgy
Copy link
Contributor

Bobgy commented Mar 6, 2020

It seems keeping uploading versions to the same pipeline and maybe auto refresh the pipeline detail page showing latest result is a good enough UX.

@Bobgy
Copy link
Contributor

Bobgy commented Mar 6, 2020

WDUT?

@Bobgy Bobgy removed the priority/p1 label Mar 6, 2020
@amygdala
Copy link
Contributor Author

amygdala commented Mar 6, 2020

Yeah, I think we can consider it lower-priority. (though if we get some breathing room it would be a 'nice to have').

@rmgogogo rmgogogo self-assigned this Jun 5, 2020
@rmgogogo
Copy link
Contributor

rmgogogo commented Jun 5, 2020

Middle/long term plan: this one can be handled together with IR topic. when we have an IR, it can help decouple the runner with visualizer.

In short term, we may bring the argo based render to jupyter world but I think it has lower priority as it will be replaced by IR based sooner or later. SG?

@Bobgy
Copy link
Contributor

Bobgy commented Jun 5, 2020

@rmgogogo I think @Ark-kun's main proposal is that putting something to jupyter is minimal cost, jupyter just takes a url to show something. If we have a page that only shows the content, it will work by itself.

So it doesn't really have any conflict with IR.

@stale
Copy link

stale bot commented Sep 4, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the lifecycle/stale The issue / pull request is stale, any activities remove this label. label Sep 4, 2020
@Bobgy
Copy link
Contributor

Bobgy commented Sep 6, 2020

/lifecycle frozen

@k8s-ci-robot k8s-ci-robot added lifecycle/frozen and removed lifecycle/stale The issue / pull request is stale, any activities remove this label. labels Sep 6, 2020
Linchin pushed a commit to Linchin/pipelines that referenced this issue Apr 11, 2023
@rimolive
Copy link
Member

rimolive commented Apr 5, 2024

Closing this issue. No activity for more than a year.

/close

Copy link

@rimolive: Closing this issue.

In response to this:

Closing this issue. No activity for more than a year.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests