Improved the IBM - Create kubernetes secret component (#1027)

Fixed the following issues:
* Checking that every command finishes successfully (non-zero return code)
* Fixed the path for the secret_name output (the program was producing variable paths different from the path in component.yaml)

components/ibm-components/commons/config/component.yaml

@@ -27,7 +27,6 @@ implementation:
       /app/config.py,
       --token, {inputValue: token},
       --url, {inputValue: url},
-      --name, {inputValue: name}
+      --name, {inputValue: name},
+      --output-secret-name-file, {outputPath: secret_name},
     ]
-    fileOutputs:
-      secret_name: /tmp/ai-pipeline-creds

components/ibm-components/commons/config/src/config.py

@@ -16,6 +16,7 @@
     parser.add_argument('--token', type=str, required=True)
     parser.add_argument('--url', type=str, required=True)
     parser.add_argument('--name', type=str)
+    parser.add_argument('--output-secret-name-file', type=str)
     args = parser.parse_args()
 
     access_token = args.token
@@ -28,13 +29,13 @@
     config_file = os.path.basename(config_file_path)
     config_local_path = os.path.join('/tmp', config_file)
     command = ['curl', '-H', 'Authorization: token %s' % access_token, '-L', '-o', config_local_path, config_file_path]
-    subprocess.run(command)
+    subprocess.run(command, check=True)
 
     secret_name = args.name
     if (not secret_name):
         secret_name = 'ai-pipeline-' + os.path.splitext(config_file)[0]
     command = ['kubectl', 'delete', 'secret', secret_name]
-    subprocess.run(command)
+    subprocess.run(command, check=True)
 
     # gather all secrets
     command = ['kubectl', 'create', 'secret', 'generic', secret_name]
@@ -47,12 +48,12 @@
             command.append('--from-literal=%s=\'%s\'' % (key, config[section][key]))
 
     # create the secret
-    subprocess.run(command)
+    subprocess.run(command, check=True)
 
     # verify secret is created
-    subprocess.run(['kubectl', 'describe', 'secret', secret_name])
+    subprocess.run(['kubectl', 'describe', 'secret', secret_name], check=True)
 
-    # indicate that secret is created
-    with open("/tmp/" + secret_name, "w") as f:
-        f.write('created')
-    f.close()
+    # indicate that secret is created and pass the secret name forward
+    from pathlib import Path
+    Path(args.output_secret_name_file).parent.mkdir(parents=True, exist_ok=True)
+    Path(args.output_secret_name_file).write_text(secret_name)