Improved the "IBM - Create kubernetes secret" component

[Ark-kun]

Fixed the following issues:

• Checking that every command finishes successfully (non-zero return code)
• Fixed the path for the secret_name output (the program was producing variable paths different from the path in component.yaml)

---

This change is 

[animeshsingh]

Thanks @Ark-kun. The idea here was to create a secret, and assign to kubernetes Apiserver, by using kubectl create secret command, rather than passing that as an input param for next component.

[Ark-kun]

Thanks @Ark-kun. The idea here was to create a secret, and assign to kubernetes Apiserver, by using kubectl create secret command, rather than passing that as an input param for next component.

I understand that. I just noticed that the created secret can have inferred name which is deduced from the URL. Also having any output makes it easier to chain dependent tasks.

I can remove that output if you think it's not useful.

Are there any issues with other changes?

[animeshsingh]

Thanks @Ark-kun - rest of the changes look good. I would say storing secrets in output file will still be a security hazerd, so best to remove that part.

[Ark-kun]

I would say storing secrets in output file will still be a security hazard, so best to remove that part.

Just want to clarify: we're not storing/passing the actual secret. Just the secret name. Does this alleviate the concern?

[animeshsingh]

/lgtm
/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: animeshsingh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• components/ibm-components/OWNERS [animeshsingh]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[Ark-kun]

/test kubeflow-pipeline-e2e-test

[mpoqq]

Hi @Ark-kun, is it possible to update the docker image on docker hub ? Due to your changes the component.yaml pulls an old image and therefore this error config.py: error: unrecognized arguments: --output-secret-name-file /outputs/secret_name/data occurs.

[animeshsingh]

we will take care of it @mpoqq

[mpoqq]

Thanks @animeshsingh, I think Watson Sample is also outdated.

[animeshsingh]

@mpoqq the sample was updated recently, its dependent on the secret component and docker image though. key thing is even if the docker image doesn't go all the way, its able to create the secrets, so rest of the steps can continue. But we are going to update the image today. If you found any issue while running samples, please let us know