Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup GitHub org file #516

Merged

Conversation

thesuperzapper
Copy link
Member

@thesuperzapper thesuperzapper commented Dec 8, 2021

This PR does NOT add or remove any members from teams, it is only about cleaning up the org.yaml file.

Actions Taken:

  1. Use members rather than maintainers to define teams
    • Without this change, non-org-admins can make additions/removals to teams without making PRs into this repo
    • This is recommended at the top of the org.yaml file.
  2. Sorts all members and repos lists alphabetically
  3. Removes references to repos that were deleted in Archive inactive Kubeflow repos community#479:
    • kubeflow/fastpages
    • kubeflow/features
    • kubeflow/homebrew-cask
    • kubeflow/homebrew-core
    • kubeflow/triage-issues
  4. Sets the description of company teams as:
    • Team of members from {COMPANY_NAME}
  5. Sets the description of teams that give write access to a single repo as:
    • Maintainers of {REPO_NAME}
  6. Sets the description of Working Group teams as:
    • Team of {GROUP_NAME} Working Group leads

@thesuperzapper
Copy link
Member Author

/assign @zijianjoy

@thesuperzapper
Copy link
Member Author

@zijianjoy I have rebased this PR, I would appreciate your approval as soon as you can.

This PR is important because it:

  1. Close a security hole (stop defining GitHub team members as managers, as this allows adding/removing members outside of this PR process, potentially resulting in privilege escalation)
  2. Cleanup the names of the GitHub teams
  3. Remove references to deleted GitHub repos

@zijianjoy
Copy link
Contributor

/lgtm
/approve

Thank you Mathew for keeping the org file up-to-date and following standard!

@google-oss-prow google-oss-prow bot added the lgtm label Jan 21, 2022
@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: thesuperzapper, zijianjoy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit d8043db into kubeflow:master Jan 21, 2022
@thesuperzapper thesuperzapper deleted the cleanup-github-org-yaml branch January 23, 2022 22:18
zijianjoy pushed a commit to zijianjoy/internal-acls that referenced this pull request Oct 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants