Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add logLevel as a helm value property under kubecostModel instead of extraEnv configuration #3717

Merged
merged 5 commits into from
Oct 22, 2024
Merged

Add logLevel as a helm value property under kubecostModel instead of extraEnv configuration #3717

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
1f88f1d
add logLevel as a helm value property under kubecostModel instead of …
mittal-ishaan Oct 17, 2024
bca40bb
add comments
mittal-ishaan Oct 17, 2024
8f73173
add defaults
mittal-ishaan Oct 17, 2024
70be2a9
remove default values from template
mittal-ishaan Oct 17, 2024
b4eeaf0
get it outside the if statement
mittal-ishaan Oct 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions cost-analyzer/templates/cost-analyzer-deployment-template.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -740,6 +740,8 @@ spec:
- name: GRAFANA_ENABLED
value: "{{ template "cost-analyzer.grafanaEnabled" . }}"
{{- end}}
- name: LOG_LEVEL
value: {{ .Values.kubecostModel.logLevel }}
{{- if .Values.kubecostModel.extraEnv -}}
{{ toYaml .Values.kubecostModel.extraEnv | nindent 12 }}
{{- end }}
Expand Down
2 changes: 1 addition & 1 deletion cost-analyzer/templates/cost-analyzer-network-costs-template.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@ spec:
- name: TRAFFIC_LOGGING_ENABLED
value: {{ (quote .Values.networkCosts.trafficLogging) | default (quote true) }}
- name: LOG_LEVEL
value: {{ .Values.networkCosts.logLevel | default "info" }}
value: {{ .Values.networkCosts.logLevel }}
{{- if .Values.networkCosts.softMemoryLimit }}
- name: GOMEMLIMIT
value: {{ .Values.networkCosts.softMemoryLimit }}
Expand Down
7 changes: 5 additions & 2 deletions cost-analyzer/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -555,6 +555,9 @@ kubecostModel:
# image provided (registry, image, tag) will be used for cost-model.
# fullImageName:

# Log level for the cost model container. Options are "trace", "debug", "info", "warn", "error", "fatal", "panic"
logLevel: info

# securityContext:
# readOnlyRootFilesystem: true

Expand Down Expand Up @@ -708,8 +711,6 @@ kubecostModel:

# Optional. A list of extra environment variables to be added to the cost-model container.
# extraEnv:
# - name: LOG_LEVEL
# value: trace
# - name: LOG_FORMAT
# value: json
# # When false, Kubecost will not show Asset costs for local disks physically
Expand Down Expand Up @@ -2307,6 +2308,7 @@ networkCosts:
# every 30 minutes.
trafficLogging: true

# Log level for the network cost containers. Options are "trace", "debug", "info", "warn", "error", "fatal", "panic"
logLevel: info

# Port will set both the containerPort and hostPort to this value.
Expand Down Expand Up @@ -2524,6 +2526,7 @@ kubecostAggregator:
# `deployMethod: "statefulset"`
replicas: 1

# Log level for the aggregator container. Options are "trace", "debug", "info", "warn", "error", "fatal", "panic"
logLevel: info

# stagingEmptyDirSizeLimit changes how large the "staging"
Expand Down