Add logLevel as a helm value property under kubecostModel instead of extraEnv configuration #3717
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…extraEnv configuration
thomasvn
reviewed
Oct 17, 2024
thomasvn
reviewed
Oct 17, 2024
thomasvn
approved these changes
Oct 22, 2024
This was referenced Nov 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR change?
Adds log level as a helm value property for kubecostModel to make it easier to be configured by the user.
Does this PR rely on any other PRs?
NA
How does this PR impact users? (This is the kind of thing that goes in release notes!)
Adds log level as a helm value property for kubecostModel to make it easier to be configured by the user. Right now the user has to add an extraEnv for log level to make it work out.
Links to Issues or tickets this PR addresses or fixes
What risks are associated with merging this PR? What is required to fully test this PR?
NA
How was this PR tested?
deployed kubecost by setting the helm values as
I was able to see debug logs in cost-model container
Have you made an update to documentation? If so, please provide the corresponding PR.
Not yet but will do