Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More conservative clippy fixes #1417

Merged
merged 1 commit into from
Mar 5, 2024
Merged

More conservative clippy fixes #1417

merged 1 commit into from
Mar 5, 2024

Conversation

clux
Copy link
Member

@clux clux commented Mar 5, 2024

this fixes CI, but doesn't clean up the unused imports that arise from being used with features, might do that later.

(running clippy --fix without --all-features is a bad idea #1416)

running clippy fix without all features is a bad idea.

Signed-off-by: clux <sszynrae@gmail.com>
@clux clux added the changelog-exclude changelog excluded prs label Mar 5, 2024
@clux clux added this to the 0.89.0 milestone Mar 5, 2024
Copy link

codecov bot commented Mar 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.2%. Comparing base (45c2ebb) to head (a88704b).

Additional details and impacted files
@@          Coverage Diff          @@
##            main   #1417   +/-   ##
=====================================
  Coverage   72.2%   72.2%           
=====================================
  Files         75      75           
  Lines       6485    6485           
=====================================
  Hits        4680    4680           
  Misses      1805    1805           
Files Coverage Δ
kube-client/src/api/subresource.rs 44.0% <100.0%> (ø)
kube-runtime/src/events.rs 97.3% <ø> (ø)
kube-runtime/src/watcher.rs 38.2% <ø> (ø)

@clux clux marked this pull request as ready for review March 5, 2024 20:48
@clux clux merged commit df37c99 into main Mar 5, 2024
18 checks passed
@clux clux deleted the clippy-fix2 branch March 5, 2024 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog-exclude changelog excluded prs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant