Skip to content

Commit

Permalink
More conservative clippy fixes (#1417)
Browse files Browse the repository at this point in the history
running clippy fix without all features is a bad idea.

Signed-off-by: clux <sszynrae@gmail.com>
  • Loading branch information
clux authored Mar 5, 2024
1 parent 45c2ebb commit df37c99
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 13 deletions.
9 changes: 2 additions & 7 deletions kube-client/src/api/subresource.rs
Original file line number Diff line number Diff line change
Expand Up @@ -545,14 +545,9 @@ where
K: Clone + DeserializeOwned + Execute,
{
/// Execute a command in a pod
pub async fn exec<I: Debug, T>(
&self,
name: &str,
command: I,
ap: &AttachParams,
) -> Result<AttachedProcess>
pub async fn exec<I, T>(&self, name: &str, command: I, ap: &AttachParams) -> Result<AttachedProcess>
where
I: IntoIterator<Item = T>,
I: IntoIterator<Item = T> + Debug,
T: Into<String>,
{
let mut req = self
Expand Down
3 changes: 1 addition & 2 deletions kube-runtime/src/events.rs
Original file line number Diff line number Diff line change
Expand Up @@ -20,8 +20,7 @@ pub struct Event {

/// The short reason explaining why the `action` was taken.
///
/// This must be at most 128 characters, and is often PascalCased. Shows up in `kubectl describe` as `Reason`.
/// Usually denoted
/// This must be at most 128 characters, generally in `PascalCase`. Shows up in `kubectl describe` as `Reason`.
pub reason: String,

/// A optional description of the status of the `action`.
Expand Down
8 changes: 4 additions & 4 deletions kube-runtime/src/watcher.rs
Original file line number Diff line number Diff line change
Expand Up @@ -206,7 +206,7 @@ pub enum InitialListStrategy {
/// List first, then watch from given resouce version
///
/// This is the old and default way of watching. The watcher will do a paginated list call first before watching.
/// When using this mode, you can configure the page_size on the watcher.
/// When using this mode, you can configure the `page_size` on the watcher.
#[default]
ListWatch,
/// Kubernetes 1.27 Streaming Lists
Expand Down Expand Up @@ -245,10 +245,10 @@ pub struct Config {

/// Control how the watcher fetches the initial list of objects.
///
/// ListWatch: The watcher will fetch the initial list of objects using a list call.
/// StreamingList: The watcher will fetch the initial list of objects using a watch call.
/// - `ListWatch`: The watcher will fetch the initial list of objects using a list call.
/// - `StreamingList`: The watcher will fetch the initial list of objects using a watch call.
///
/// StreamingList is more efficient than ListWatch, but it requires the server to support
/// `StreamingList` is more efficient than `ListWatch`, but it requires the server to support
/// streaming list bookmarks (opt-in feature gate in Kubernetes 1.27).
///
/// See [upstream documentation on streaming lists](https://kubernetes.io/docs/reference/using-api/api-concepts/#streaming-lists),
Expand Down

0 comments on commit df37c99

Please sign in to comment.