This repository has been archived by the owner on Dec 1, 2018. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 9
Standardised (corrected) printing of pid
#56
Open
Sebbyastian
wants to merge
275
commits into
kristapsdz:master
Choose a base branch
from
Sebbyastian:patch-1
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… that netproc failing doesn't cause short reads and exits.
…g but looks up addresses as used by netproc.
Prune a lot of unused variables.
kristapsdz/acme-client-portable#12 that pushes the check for file pre-existence with -n and -N only into the main process, stripping out the arguments before passing them to the child. This fixes a race condition.
allows certain variables to be overriden. This allows us to provide -nN and have them properly be nullified by the child processes.
…back- port that to the older API of libressl.
…ortable#13 . This creates a triplet exported to the operator: challenge type, domain, and print.
…s can be noted approriately. From kristapsdz#29 -- thanks!
…s will make this optional.)
…p to date version of libressl out there.
…versions as old as that.
…nginx and Apache (more to come). Inspired by kristapsdz#32 --- thanks!
There exists no perfect format delegate for `pid_t`, but one thing we can be sure of, the return value of the `fork` manual tells us `pid_t` must be a signed type (as -1 is a potential value). Thus, the unsigned format delegates are probably the choices least portable/most deceptive to us debuggers.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There exists no perfect format delegate for
pid_t
, but one thing we can be sure of, the return value of thefork
manual tells uspid_t
must be a signed type (as -1 is a potential value). Thus, the unsigned format delegates are probably the choices least portable/most deceptive to us debuggers.