This repository has been archived by the owner on Dec 1, 2018. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 21
present more challenge metadata for non-http challenge types #13
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When -t is used to perform a challenge using dns-01 or some other hypothetical challenge type, only the token and thumbprint are displayed. That's not enough information to set up challenge response manually. This patch extends the chngproc IPC semantics and the stdout from netproc to provide the challenge type and domain name being challenged. That's enough for external challenge setup. This particularly comes into interest when retrieving a single certificate with multiple subjectAlternativeNames, especially when those alt names are in different DNS domains and might require different account authorizations to perform updates.
Good point. I figured the challenge part would be obvious because it's required in invoking the acme-client process, but it can't hurt. Can you update the manpage as well in your patch? |
Ah, yes - I will do that. It's a holiday here, will get to this in the next couple of days. |
I took the liberty of expanding the text on -t and of adding an example. Happy to make any changes you prefer. |
Looks interesting. Is there an ETA for merging this PR? |
kristapsdz
pushed a commit
to kristapsdz/acme-client
that referenced
this pull request
Jan 28, 2017
…ortable#13 . This creates a triplet exported to the operator: challenge type, domain, and print.
kristapsdz
pushed a commit
to kristapsdz/acme-client
that referenced
this pull request
Jan 28, 2017
@kristapsdz, thanks for the clarification. Point taken. |
kristapsdz
pushed a commit
to kristapsdz/acme-client
that referenced
this pull request
Dec 1, 2018
…ortable#13 . This creates a triplet exported to the operator: challenge type, domain, and print.
kristapsdz
pushed a commit
to kristapsdz/acme-client
that referenced
this pull request
Dec 1, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When -t is used to perform a challenge using dns-01 or some other
hypothetical challenge type, only the token and thumbprint are
displayed. That's not enough information to set up challenge response
manually. This patch extends the chngproc IPC semantics and the
stdout from netproc to provide the challenge type and domain name
being challenged. That's enough for external challenge setup.
This particularly comes into interest when retrieving a single
certificate with multiple subjectAlternativeNames, especially when those
alt names are in different DNS domains and might require different
account authorizations to perform updates.