Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add gtfs2vec #169

Merged
merged 49 commits into from
Feb 22, 2023
Merged

feat: add gtfs2vec #169

merged 49 commits into from
Feb 22, 2023

Conversation

piotrgramacki
Copy link
Collaborator

Closes #146

#150 must be merged prior to this one!

@piotrgramacki piotrgramacki linked an issue Feb 6, 2023 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Feb 6, 2023

Codecov Report

Merging #169 (06da67b) into main (050bda4) will decrease coverage by 0.16%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #169      +/-   ##
==========================================
- Coverage   99.17%   99.02%   -0.16%     
==========================================
  Files          26       30       +4     
  Lines         604      715     +111     
==========================================
+ Hits          599      708     +109     
- Misses          5        7       +2     
Flag Coverage Δ
macos-latest-python3.10 99.02% <100.00%> (?)
macos-latest-python3.11 ?
ubuntu-latest-python3.10 98.88% <100.00%> (+0.20%) ⬆️
ubuntu-latest-python3.11 ?
ubuntu-latest-python3.8 98.87% <100.00%> (+0.04%) ⬆️
ubuntu-latest-python3.9 98.87% <100.00%> (+0.20%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
srai/embedders/__init__.py 100.00% <100.00%> (ø)
srai/embedders/base.py 100.00% <100.00%> (ø)
srai/embedders/count_embedder.py 100.00% <100.00%> (ø)
srai/embedders/gtfs2vec_embedder.py 100.00% <100.00%> (ø)
srai/loaders/gtfs_loader.py 100.00% <100.00%> (ø)
srai/models/__init__.py 100.00% <100.00%> (ø)
srai/models/gtfs2vec_model.py 100.00% <100.00%> (ø)
srai/utils/exceptions.py 100.00% <100.00%> (ø)
.../regionizers/administrative_boundary_regionizer.py 93.20% <0.00%> (-1.95%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@piotrgramacki piotrgramacki marked this pull request as ready for review February 13, 2023 14:19
srai/utils/constants.py Outdated Show resolved Hide resolved
srai/models/gtfs2vec_model.py Outdated Show resolved Hide resolved
pyproject.toml Show resolved Hide resolved
srai/embedders/gtfs2vec_embedder.py Outdated Show resolved Hide resolved
srai/embedders/gtfs2vec_embedder.py Outdated Show resolved Hide resolved
srai/embedders/gtfs2vec_embedder.py Outdated Show resolved Hide resolved
Calychas
Calychas previously approved these changes Feb 13, 2023
Copy link
Collaborator

@Calychas Calychas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

srai/utils/constants.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@simonusher simonusher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall. There's that thing with types-requests but I'm not sure how important it is.

pyproject.toml Outdated Show resolved Hide resolved
@piotrgramacki piotrgramacki merged commit 77ee8a8 into main Feb 22, 2023
@piotrgramacki piotrgramacki deleted the 146-implement-gtfs2vec branch February 22, 2023 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement gtfs2vec
3 participants