Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add gtfs2vec #169

Merged
merged 49 commits into from
Feb 22, 2023
Merged

feat: add gtfs2vec #169

merged 49 commits into from
Feb 22, 2023

Conversation

piotrgramacki
Copy link
Collaborator

Closes #146

#150 must be merged prior to this one!

piotrgramacki and others added 24 commits December 23, 2022 01:43
@piotrgramacki
chore: add gtfs_kit dependency
b363049
@piotrgramacki
chore: add trips count to GTFSLoader
7aaf411
@piotrgramacki
fix: remove time_resolution from loader init
b286a72
@piotrgramacki
chore: load directions from gtfs feed
3778e9c
@piotrgramacki
Merge branch 'main' into 145-implement-gtfs-loader
8823bff
@piotrgramacki
fix: update pdm.lock
161ea14
@piotrgramacki
Merge branch 'main' into 145-implement-gtfs-loader
37955c8
@piotrgramacki
fix: make gtfs_kit import optional, fix imports in __init__.py, use W…
22f48d4 
…GS84_CRS constant
@piotrgramacki
chore: add example notebook for GTFSLoader
719fff3
@piotrgramacki
chore: add GTFS feed validation
1337290
@piotrgramacki
fix: use warnings for gtfs validation error
ce21888
@piotrgramacki
test: add pytest-mock dependency and gtfs loader validation tests
a7c21b7
@piotrgramacki
fix: handle faulty B028 error from flake8
cac509e
@piotrgramacki
test: add GTFSLoader tests
4b59f0d
@piotrgramacki
chore: update CHANGELOG
bead054
@piotrgramacki
fix: properly type GTFSLoader methods
e3edd50
@piotrgramacki
fix: add missing no cover comment
34361a4
@piotrgramacki
fix: improve load docstring
7370133
@piotrgramacki
fix: remove newest gtfs_kit version from requirements and add min sup…
5f1fe7c 
…ported version
@piotrgramacki
fix: extract departure time parsing to method
f4d9abd
@piotrgramacki
test: reuse fixtures which are not modified
0dac59d
@piotrgramacki
fix: update wrong fixture scope
8d3d189
@piotrgramacki
fix: download example gtfs without wget
e56a781
@piotrgramacki
test: add gtfs_kit to optional dependencies tests
a24e8c2
@piotrgramacki piotrgramacki linked an issue Feb 6, 2023 that may be closed by this pull request
Implement gtfs2vec #146
Closed
@codecov
Copy link

codecov bot commented Feb 6, 2023 •
edited
Loading

Codecov Report

Merging #169 (06da67b) into main (050bda4) will decrease coverage by 0.16%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #169      +/-   ##
==========================================
- Coverage   99.17%   99.02%   -0.16%     
==========================================
  Files          26       30       +4     
  Lines         604      715     +111     
==========================================
+ Hits          599      708     +109     
- Misses          5        7       +2
Flag Coverage Δ
macos-latest-python3.10 99.02% <100.00%> (?)
macos-latest-python3.11 ?
ubuntu-latest-python3.10 98.88% <100.00%> (+0.20%) ⬆️
ubuntu-latest-python3.11 ?
ubuntu-latest-python3.8 98.87% <100.00%> (+0.04%) ⬆️
ubuntu-latest-python3.9 98.87% <100.00%> (+0.20%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
srai/embedders/__init__.py 100.00% <100.00%> (ø)
srai/embedders/base.py 100.00% <100.00%> (ø)
srai/embedders/count_embedder.py 100.00% <100.00%> (ø)
srai/embedders/gtfs2vec_embedder.py 100.00% <100.00%> (ø)
srai/loaders/gtfs_loader.py 100.00% <100.00%> (ø)
srai/models/__init__.py 100.00% <100.00%> (ø)
srai/models/gtfs2vec_model.py 100.00% <100.00%> (ø)
srai/utils/exceptions.py 100.00% <100.00%> (ø)
.../regionizers/administrative_boundary_regionizer.py 93.20% <0.00%> (-1.95%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

@piotrgramacki piotrgramacki self-assigned this Feb 9, 2023
@piotrgramacki piotrgramacki marked this pull request as ready for review February 13, 2023 14:19
simonusher
simonusher requested changes Feb 13, 2023
View reviewed changes
srai/utils/constants.py Outdated Show resolved Hide resolved
srai/models/gtfs2vec_model.py Outdated Show resolved Hide resolved
pyproject.toml Show resolved Hide resolved
srai/embedders/gtfs2vec_embedder.py Outdated Show resolved Hide resolved
srai/embedders/gtfs2vec_embedder.py Outdated Show resolved Hide resolved
srai/embedders/gtfs2vec_embedder.py Outdated Show resolved Hide resolved
Calychas
Calychas previously approved these changes Feb 13, 2023
View reviewed changes
Copy link
Collaborator

@Calychas Calychas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

srai/utils/constants.py Outdated Show resolved Hide resolved
simonusher
simonusher reviewed Feb 22, 2023
View reviewed changes
Copy link
Collaborator

@simonusher simonusher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall. There's that thing with types-requests but I'm not sure how important it is.

pyproject.toml Outdated Show resolved Hide resolved
@piotrgramacki piotrgramacki merged commit 77ee8a8 into main Feb 22, 2023
@piotrgramacki piotrgramacki deleted the 146-implement-gtfs2vec branch February 22, 2023 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simonusher simonusher simonusher approved these changes

@RaczeQ RaczeQ Awaiting requested review from RaczeQ

@Calychas Calychas Awaiting requested review from Calychas

Assignees

@piotrgramacki piotrgramacki

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement gtfs2vec
3 participants
@piotrgramacki @Calychas @simonusher