Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add GTFS Loader #150

Merged
merged 28 commits into from
Feb 13, 2023
Merged

feat: add GTFS Loader #150

merged 28 commits into from
Feb 13, 2023

Conversation

piotrgramacki
Copy link
Collaborator

closes #145

@piotrgramacki piotrgramacki self-assigned this Dec 23, 2022
@piotrgramacki piotrgramacki linked an issue Dec 23, 2022 that may be closed by this pull request
Implement GTFS loader #145
Closed
@codecov
Copy link

codecov bot commented Jan 10, 2023 •
edited
Loading

Codecov Report

Merging #150 (b45cbd1) into main (2bd6fac) will increase coverage by 0.10%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #150      +/-   ##
==========================================
+ Coverage   98.96%   99.06%   +0.10%     
==========================================
  Files          20       21       +1     
  Lines         481      535      +54     
==========================================
+ Hits          476      530      +54     
  Misses          5        5
Flag Coverage Δ
macos-latest-python3.11 99.06% <100.00%> (+0.10%) ⬆️
ubuntu-latest-python3.10 98.87% <100.00%> (+0.12%) ⬆️
ubuntu-latest-python3.11 98.87% <100.00%> (+0.12%) ⬆️
ubuntu-latest-python3.8 98.87% <100.00%> (+0.12%) ⬆️
ubuntu-latest-python3.9 98.87% <100.00%> (+0.12%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
srai/loaders/__init__.py 100.00% <100.00%> (ø)
srai/loaders/gtfs_loader.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@piotrgramacki piotrgramacki marked this pull request as ready for review January 20, 2023 19:58
RaczeQ
RaczeQ requested changes Jan 20, 2023
View reviewed changes
srai/loaders/gtfs_loader.py Outdated Show resolved Hide resolved
RaczeQ
RaczeQ requested changes Jan 27, 2023
View reviewed changes
examples/loaders/gtfs_loader.ipynb Outdated Show resolved Hide resolved
@RaczeQ
Copy link
Collaborator

RaczeQ commented Jan 27, 2023

Please add tests for new dependencies group in this file: https://github.com/srai-lab/srai/blob/main/tests/miscellaneous/test_optional_dependencies.py
https://github.com/srai-lab/srai/blob/4d7f2b9cba03275d42d4447fb82f8b0c7d08f20b/tests/miscellaneous/test_optional_dependencies.py#L37-L44

@piotrgramacki piotrgramacki mentioned this pull request Feb 6, 2023
Merged
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

simonusher
simonusher reviewed Feb 13, 2023
View reviewed changes
pyproject.toml Outdated Show resolved Hide resolved
@piotrgramacki piotrgramacki merged commit 199adea into main Feb 13, 2023
@piotrgramacki piotrgramacki deleted the 145-implement-gtfs-loader branch February 13, 2023 12:52
Calychas
Calychas reviewed Feb 13, 2023
View reviewed changes
Copy link
Collaborator

@Calychas Calychas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Post factum LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Calychas Calychas Calychas left review comments

@RaczeQ RaczeQ RaczeQ approved these changes

@simonusher simonusher simonusher approved these changes

Assignees

@piotrgramacki piotrgramacki

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement GTFS loader
4 participants
@piotrgramacki @RaczeQ @Calychas @simonusher