Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add OSM tag loader #167

Merged
merged 18 commits into from
Feb 17, 2023
Merged

feat: add OSM tag loader #167

merged 18 commits into from
Feb 17, 2023

Conversation

simonusher
Copy link
Collaborator

No description provided.

@codecov
Copy link

codecov bot commented Jan 30, 2023

Codecov Report

Merging #167 (5424b4d) into main (199adea) will increase coverage by 0.10%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #167      +/-   ##
==========================================
+ Coverage   99.06%   99.17%   +0.10%     
==========================================
  Files          21       26       +5     
  Lines         535      604      +69     
==========================================
+ Hits          530      599      +69     
  Misses          5        5              
Flag Coverage Δ
macos-latest-python3.11 99.17% <100.00%> (+0.10%) ⬆️
ubuntu-latest-python3.10 98.67% <100.00%> (-0.21%) ⬇️
ubuntu-latest-python3.11 99.00% <100.00%> (+0.12%) ⬆️
ubuntu-latest-python3.8 99.00% <100.00%> (+0.12%) ⬆️
ubuntu-latest-python3.9 99.00% <100.00%> (+0.12%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
srai/loaders/osm_tag_loader/__init__.py 100.00% <100.00%> (ø)
srai/loaders/osm_tag_loader/filters/__init__.py 100.00% <100.00%> (ø)
srai/loaders/osm_tag_loader/filters/hex2vec.py 100.00% <100.00%> (ø)
srai/loaders/osm_tag_loader/filters/popular.py 100.00% <100.00%> (ø)
srai/loaders/osm_tag_loader/osm_tag_loader.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@simonusher simonusher requested review from Calychas, RaczeQ and piotrgramacki and removed request for Calychas January 31, 2023 00:31
@simonusher simonusher self-assigned this Jan 31, 2023
Copy link
Collaborator

@piotrgramacki piotrgramacki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update CHANGELOG.md

Calychas
Calychas previously approved these changes Feb 13, 2023
srai/loaders/osm_tag_loader/osm_tag_loader.py Outdated Show resolved Hide resolved
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

CHANGELOG.md Outdated Show resolved Hide resolved
srai/loaders/osm_tag_loader/osm_tag_loader.py Outdated Show resolved Hide resolved
piotrgramacki
piotrgramacki previously approved these changes Feb 16, 2023
Copy link
Collaborator

@piotrgramacki piotrgramacki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nicely done! I have no other comments ;)

…rea, and when there is only one result gdf (one polygon, one key-value pair)
@simonusher simonusher merged commit 050bda4 into main Feb 17, 2023
@simonusher simonusher deleted the 157-add-osm-loader branch February 17, 2023 20:31
@simonusher simonusher linked an issue Feb 23, 2023 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add OSMLoader for hex2vec use case
3 participants