Skip to content

Fix external link on apply replacements documentation #957

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ChristopherFry merged 1 commit into from
Nov 22, 2022
Merged

Fix external link on apply replacements documentation #957

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion functions/go/apply-replacements/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,4 +41,4 @@ replacements:
```
<!--mdtogo-->

[kustomize replacements]: https://kubectl.docs.kubernetes.io/references/kustomize/kustomization/replacements/
[kustomize replacements]: https://kubectl.docs.kubernetes.io/references/kustomize/kustomization/replacements/ ':target=_blank'
Copy link
Contributor

@sdowell sdowell Nov 22, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not much of a CSS expert so forgive me (I assume this is CSS). From some brief googling it looks like this tells the browser to open this link in a new tab. How does this fix the link?

Copy link
Contributor Author

@ChristopherFry ChristopherFry Nov 22, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good question. Essentially we're hitting a cross-origin issue here. We're on domain A, and the browser isn't allowing us to redirect to domain B.

I'm taking a slightly opinionated approach to correct this. Since we're linking to an external domain, I'm choosing to link to it by opening up a new tab. This is consistent with kpt.dev Contact page and Config Sync documentation. Being this is in a new tab, browsing to domain B directly is allowed.

Another way I can resolve this is similar to what we do in the sidebar, and add the :crossorgin. This would correct the issue allowing us to browse to the domain B in the same tab.

Copy link
Contributor

@sdowell sdowell Nov 22, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SGTM if this is consistent with other external links