Fix external link on apply replacements documentation #957
Conversation
ChristopherFry
requested review from
droot,
sdowell and
yuwenma
as code owners
| <!--mdtogo--> | ||
| [kustomize replacements]: https://kubectl.docs.kubernetes.io/references/kustomize/kustomization/replacements/ | ||
| [kustomize replacements]: https://kubectl.docs.kubernetes.io/references/kustomize/kustomization/replacements/ ':target=_blank' |
There was a problem hiding this comment.
I'm not much of a CSS expert so forgive me (I assume this is CSS). From some brief googling it looks like this tells the browser to open this link in a new tab. How does this fix the link?
There was a problem hiding this comment.
Good question. Essentially we're hitting a cross-origin issue here. We're on domain A, and the browser isn't allowing us to redirect to domain B.
I'm taking a slightly opinionated approach to correct this. Since we're linking to an external domain, I'm choosing to link to it by opening up a new tab. This is consistent with kpt.dev Contact page and Config Sync documentation. Being this is in a new tab, browsing to domain B directly is allowed.
Another way I can resolve this is similar to what we do in the sidebar, and add the :crossorgin. This would correct the issue allowing us to browse to the domain B in the same tab.
There was a problem hiding this comment.
SGTM if this is consistent with other external links
2 participants
Fixes the external link on the apply replacements function documentation in reference to kptdev/kpt/issues/3594.