Skip to content

update ark and runtime version #52

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lvjing2 merged 1 commit into from
Nov 12, 2024
Merged

update ark and runtime version #52

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions dubbo-samples/rpc/dubbo26/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,8 +28,8 @@
<dubbo.version>2.6.12</dubbo.version>
<dubbo.spring.boot.version>0.2.1.RELEASE</dubbo.spring.boot.version>
<spring.boot.version>2.7.16</spring.boot.version>
<koupleless.runtime.version>1.3.1</koupleless.runtime.version>
<sofa.ark.version>2.2.14</sofa.ark.version>
<koupleless.runtime.version>1.3.2</koupleless.runtime.version>
<sofa.ark.version>2.2.15</sofa.ark.version>
<disruptor.version>3.4.2</disruptor.version>
<maven.compiler.plugin.version>3.8.1</maven.compiler.plugin.version>
</properties>
Expand Down
4 changes: 2 additions & 2 deletions dubbo-samples/rpc/dubbo27/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,8 +27,8 @@
<maven.compiler.target>8</maven.compiler.target>
<dubbo.version>2.7.23</dubbo.version>
<spring.boot.version>2.7.16</spring.boot.version>
<koupleless.runtime.version>1.3.1</koupleless.runtime.version>
<sofa.ark.version>2.2.14</sofa.ark.version>
<koupleless.runtime.version>1.3.2</koupleless.runtime.version>
<sofa.ark.version>2.2.15</sofa.ark.version>
Comment on lines +30 to +31
Copy link

@coderabbitai coderabbitai bot Nov 12, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codebase verification

Version 1.3.2 of koupleless-runtime is not yet available

The version update to koupleless-runtime 1.3.2 cannot be verified as available:

  • The version is not found in Maven Central repository
  • No GitHub release tag exists for v1.3.2
  • Although the version is referenced across multiple pom.xml files in the repository, using an unavailable version will cause build failures

Recommendations:

  • Keep the current stable version until 1.3.2 is officially released
  • Alternatively, verify if this version is available in a different artifact repository that's configured in the project
🔗 Analysis chain

Verify the availability and stability of the updated versions

The version updates look reasonable as they are patch version increments, suggesting backward compatibility. Let's verify the availability and stability of these versions.

Let me verify the availability of these versions in other repositories since Maven Central shows koupleless 1.3.2 is not available.

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Verify the availability and stability of the updated versions

# Check if the versions exist in Maven Central
echo "Checking koupleless runtime version 1.3.2..."
curl -s "https://search.maven.org/solrsearch/select?q=g:com.alipay.sofa.koupleless+AND+a:koupleless-base-starter+AND+v:1.3.2" | jq '.response.numFound'

echo "Checking sofa ark version 2.2.15..."
curl -s "https://search.maven.org/solrsearch/select?q=g:com.alipay.sofa+AND+a:sofa-ark-all+AND+v:2.2.15" | jq '.response.numFound'

# Check for any known issues in GitHub
echo "Checking for recent issues related to these versions..."
gh api graphql -f query='
{
  search(query: "repo:koupleless/koupleless is:issue label:bug 1.3.2", type: ISSUE, first: 5) {
    nodes {
      ... on Issue {
        title
        state
        createdAt
      }
    }
  }
}'

Length of output: 846

Script:

#!/bin/bash
# Check if the versions are available in other repositories
echo "Checking for koupleless 1.3.2 in GitHub packages..."
curl -s "https://api.github.com/repos/koupleless/koupleless/releases/tags/v1.3.2"

echo -e "\nChecking for references to version 1.3.2 in the repository..."
rg "1\.3\.2" --type xml

echo -e "\nChecking for any release notes or changelog entries..."
fd -g "CHANGELOG*" -X cat

Length of output: 1569

<disruptor.version>3.4.2</disruptor.version>
<maven.compiler.plugin.version>3.8.1</maven.compiler.plugin.version>
</properties>
Expand Down
4 changes: 2 additions & 2 deletions dubbo-samples/rpc/dubbo3/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,8 +27,8 @@
<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
<project.reporting.outputEncoding>UTF-8</project.reporting.outputEncoding>
<spring.boot.version>2.7.16</spring.boot.version>
<koupleless.runtime.version>1.3.1</koupleless.runtime.version>
<sofa.ark.version>2.2.14</sofa.ark.version>
<koupleless.runtime.version>1.3.2</koupleless.runtime.version>
<sofa.ark.version>2.2.15</sofa.ark.version>
<disruptor.version>3.4.2</disruptor.version>
<maven.compiler.plugin.version>3.8.1</maven.compiler.plugin.version>
<dubbo.version>3.1.11</dubbo.version>
Expand Down
4 changes: 2 additions & 2 deletions dubbo32-samples/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,8 @@

<properties>
<spring.boot.version>3.2.2</spring.boot.version>
<sofa.ark.version>3.1.7</sofa.ark.version>
<koupleless.runtime.version>2.1.6</koupleless.runtime.version>
<sofa.ark.version>3.1.8</sofa.ark.version>
<koupleless.runtime.version>2.1.7</koupleless.runtime.version>
<dubbo.version>3.2.10</dubbo.version>
<license.maven.plugin>3.0</license.maven.plugin>
<maven.java.formatter.plugin>0.4</maven.java.formatter.plugin>
Expand Down
4 changes: 2 additions & 2 deletions feature-samples/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,8 @@

<properties>
<java.version>1.8</java.version>
<koupleless.runtime.version>1.3.1</koupleless.runtime.version>
<sofa.ark.version>2.2.14</sofa.ark.version>
<koupleless.runtime.version>1.3.2</koupleless.runtime.version>
<sofa.ark.version>2.2.15</sofa.ark.version>
Comment on lines +15 to +16
Copy link

@coderabbitai coderabbitai bot Nov 12, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codebase verification

Version inconsistency detected across different sample modules

The version verification reveals inconsistencies:

  • SpringBoot3 samples use:

    • koupleless.runtime.version: 2.1.7
    • sofa.ark.version: 3.1.8

  • SpringBoot/SpringBoot1/Feature samples use:

    • koupleless.runtime.version: 1.3.2
    • sofa.ark.version: 2.2.15

This version mismatch between different sample modules could lead to compatibility issues. The versions should be aligned unless there's a specific reason for the difference.

🔗 Analysis chain

Verify version compatibility and changelog

The version updates look consistent with other pom.xml files in the PR:

  • koupleless.runtime.version: 1.3.2
  • sofa.ark.version: 2.2.15

Let's verify these versions:

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Check if these are the latest stable versions and if there are any breaking changes

# Search for version declarations across all pom files to ensure consistency
echo "Checking version consistency across pom files..."
rg -g "pom.xml" "koupleless\.runtime\.version|sofa\.ark\.version"

# Check if these versions exist in the respective repositories
echo "Checking koupleless releases..."
gh api repos/koupleless/koupleless/releases --jq '.[].tag_name'

echo "Checking sofa-ark releases..."
gh api repos/sofastack/sofa-ark/releases --jq '.[].tag_name'

Length of output: 23055

<disruptor.version>3.4.2</disruptor.version>
<os.plugin.version>1.7.1</os.plugin.version>
<protobuf.plugin.version>0.6.1</protobuf.plugin.version>
Expand Down
4 changes: 2 additions & 2 deletions sofaboot-samples/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,8 +21,8 @@

<properties>
<java.version>1.8</java.version>
<koupleless.runtime.version>1.3.1</koupleless.runtime.version>
<sofa.ark.version>2.2.14</sofa.ark.version>
<koupleless.runtime.version>1.3.2</koupleless.runtime.version>
<sofa.ark.version>2.2.15</sofa.ark.version>
Comment on lines +24 to +25
Copy link

@coderabbitai coderabbitai bot Nov 12, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codebase verification

Version update needs revision - koupleless 1.3.2 appears to be premature

The version update to koupleless 1.3.2 appears problematic:

  • Latest released version is 1.3.1 (from September 2024)
  • Version 1.3.2 is being used across multiple sample projects but hasn't been officially released
  • The sofa-ark update to 2.2.15 is correct and matches the latest release

Recommend:

  • Revert koupleless version to 1.3.1 until 1.3.2 is officially released
  • Keep sofa-ark version at 2.2.15
🔗 Analysis chain

Verify the version updates and their implications.

The version updates look consistent with the coordinated dependency management across projects. However, let's verify:

  1. That these are the latest stable versions
  2. Any breaking changes or known issues

Version updates need attention - koupleless version appears outdated

Based on the GitHub releases data:

  • The koupleless version being updated to (1.3.2) is not yet released - latest is v1.3.1 from September 2024
  • The sofa-ark version update to 2.2.15 matches the latest release in that series from November 2024

Let's verify if there are any references to version 1.3.2 in the repository:

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Verify latest versions and changelogs for koupleless and sofa-ark

# Check for koupleless releases
echo "Checking koupleless releases..."
gh api repos/koupleless/koupleless/releases --jq '.[0:3] | .[] | {tag_name, published_at}'

# Check for sofa-ark releases
echo "Checking sofa-ark releases..."
gh api repos/sofastack/sofa-ark/releases --jq '.[0:3] | .[] | {tag_name, published_at}'

# Look for any migration guides or breaking changes in recent commits
echo "Checking for breaking changes..."
gh api repos/koupleless/koupleless/commits --jq '.[] | select(.commit.message | contains("BREAKING") or contains("breaking")) | {sha, commit: {message}}'
gh api repos/sofastack/sofa-ark/commits --jq '.[] | select(.commit.message | contains("BREAKING") or contains("breaking")) | {sha, commit: {message}}'

Length of output: 1069

Script:

#!/bin/bash
# Search for any references to koupleless version 1.3.2
echo "Searching for koupleless version 1.3.2 references..."
rg "1\.3\.2" -A 2 -B 2

# Check if this is a development branch version
echo "Checking development branches..."
git branch -a | grep dev

Length of output: 4297

<guice.version>6.0.0</guice.version>
<guava.version>32.1.3-jre</guava.version>
<curator.version>2.9.1</curator.version>
Expand Down
4 changes: 2 additions & 2 deletions sofaboot4-samples/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,8 +21,8 @@

<properties>
<java.version>17</java.version>
<koupleless.runtime.version>2.1.6</koupleless.runtime.version>
<sofa.ark.version>3.1.7</sofa.ark.version>
<koupleless.runtime.version>2.1.7</koupleless.runtime.version>
<sofa.ark.version>3.1.8</sofa.ark.version>
<guice.version>6.0.0</guice.version>
<guava.version>32.1.3-jre</guava.version>
<curator.version>2.9.1</curator.version>
Expand Down
4 changes: 2 additions & 2 deletions springboot-samples/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,8 @@
<java.version>1.8</java.version>
<maven.compiler.source>8</maven.compiler.source>
<maven.compiler.target>8</maven.compiler.target>
<koupleless.runtime.version>1.3.1</koupleless.runtime.version>
<sofa.ark.version>2.2.14</sofa.ark.version>
<koupleless.runtime.version>1.3.2</koupleless.runtime.version>
<sofa.ark.version>2.2.15</sofa.ark.version>
<disruptor.version>3.4.2</disruptor.version>
<os.plugin.version>1.7.1</os.plugin.version>
<protobuf.plugin.version>0.6.1</protobuf.plugin.version>
Expand Down
4 changes: 2 additions & 2 deletions springboot1-samples/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,8 @@
<java.version>1.8</java.version>
<maven.compiler.source>8</maven.compiler.source>
<maven.compiler.target>8</maven.compiler.target>
<koupleless.runtime.version>1.3.1</koupleless.runtime.version>
<sofa.ark.version>2.2.14</sofa.ark.version>
<koupleless.runtime.version>1.3.2</koupleless.runtime.version>
<sofa.ark.version>2.2.15</sofa.ark.version>
<disruptor.version>3.4.2</disruptor.version>
<os.plugin.version>1.7.1</os.plugin.version>
<protobuf.plugin.version>0.6.1</protobuf.plugin.version>
Expand Down
4 changes: 2 additions & 2 deletions springboot3-samples/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,8 @@
<java.version>17</java.version>
<maven.compiler.source>17</maven.compiler.source>
<maven.compiler.target>17</maven.compiler.target>
<sofa.ark.version>3.1.7</sofa.ark.version>
<koupleless.runtime.version>2.1.6</koupleless.runtime.version>
<sofa.ark.version>3.1.8</sofa.ark.version>
<koupleless.runtime.version>2.1.7</koupleless.runtime.version>
<disruptor.version>3.4.2</disruptor.version>
<os.plugin.version>1.7.1</os.plugin.version>
<protobuf.plugin.version>0.6.1</protobuf.plugin.version>
Expand Down